All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [PATCH] Remove READ_IMPLIES_EXEC during restart
Date: Thu, 14 May 2009 12:10:53 -0400	[thread overview]
Message-ID: <4A0C428D.6050706@cs.columbia.edu> (raw)
In-Reply-To: <87y6u3cqd0.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>


Dan,

Now after the rework of the patchset, it's probably a good time
to add support for this.

I'm unsure if the personality can affect other restore actions
that take place elsewhere If so, probably the correct way is to:

1) restore personality as part of the task (in the beginning)

2) temporarily change it around those places where we want the
"native" personality, e.g. the call to do_mmap_pgoff(), or shmat(),

(The reason not to put it around the entire restore_mm() is to
be safe in case a personality makes a difference when you open
files. This way we isolate the effect of changing personality).

Any thoughts ?

Oren.

Dan Smith wrote:
> OL> In fact, if elsewhere we restore current->personality of the task,
> OL> then unless we move it to cr_read_mm(), it will overwrite it :(
> 
> Should we move it or just remove RIE before we start the restart and
> let the task regain the flag if it had it before?
> 

      parent reply	other threads:[~2009-05-14 16:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 17:41 [PATCH] Remove READ_IMPLIES_EXEC during restart Dan Smith
     [not found] ` <1239039694-22332-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-06 18:17   ` Serge E. Hallyn
     [not found]     ` <20090406181748.GA24751-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-14  5:59       ` Oren Laadan
     [not found]         ` <49E42646.4040703-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-14  6:05           ` Oren Laadan
     [not found]             ` <49E4278C.3060500-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-14 13:32               ` Dan Smith
     [not found]                 ` <87y6u3cqd0.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-04-14 14:40                   ` Oren Laadan
2009-05-14 16:10                   ` Oren Laadan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0C428D.6050706@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.