[PATCH] fix stubdom memory corruption

[PATCH] fix stubdom memory corruption

[Stefano Stabellini]

Hi all,
this patch fixes a memory corruption in blkfront that happens every time
we pass a sector aligned buffer (instead of a page aligned buffer) to
blkfront_aio.
To trigger the COW we have to write at least a byte to each page of the
buffer, but we must be careful not to overwrite useful content.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

diff -r dbc4014882d0 extras/mini-os/blkfront.c
--- a/extras/mini-os/blkfront.c	Wed Apr 01 08:36:21 2009 +0100
+++ b/extras/mini-os/blkfront.c	Tue Apr 14 10:18:30 2009 +0100
@@ -317,19 +317,21 @@
     req->sector_number = aiocbp->aio_offset / dev->info.sector_size;
 
     for (j = 0; j < n; j++) {
+        req->seg[j].first_sect = 0;
+        req->seg[j].last_sect = PAGE_SIZE / dev->info.sector_size - 1;
+    }
+    req->seg[0].first_sect = ((uintptr_t)aiocbp->aio_buf & ~PAGE_MASK) / dev->info.sector_size;
+    req->seg[n-1].last_sect = (((uintptr_t)aiocbp->aio_buf + aiocbp->aio_nbytes - 1) & ~PAGE_MASK) / dev->info.sector_size;
+    for (j = 0; j < n; j++) {
 	uintptr_t data = start + j * PAGE_SIZE;
         if (!write) {
             /* Trigger CoW if needed */
-            *(char*)data = 0;
+            *(char*)(data + (req->seg[j].first_sect << 9)) = 0;
             barrier();
         }
 	aiocbp->gref[j] = req->seg[j].gref =
             gnttab_grant_access(dev->dom, virtual_to_mfn(data), write);
-	req->seg[j].first_sect = 0;
-	req->seg[j].last_sect = PAGE_SIZE / dev->info.sector_size - 1;
     }
-    req->seg[0].first_sect = ((uintptr_t)aiocbp->aio_buf & ~PAGE_MASK) / dev->info.sector_size;
-    req->seg[n-1].last_sect = (((uintptr_t)aiocbp->aio_buf + aiocbp->aio_nbytes - 1) & ~PAGE_MASK) / dev->info.sector_size;
 
     dev->ring.req_prod_pvt = i + 1;

Re: [PATCH] fix stubdom memory corruption

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 2734 bytes --]

This one and vl.c patch have been applied.
stubdom has been rebuilt and reinstalled.
No improvement.
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0  7019     2     r-----    633.9
RHELhvm                                     1  1024     1     ------      0.0
root@ServerXen331:/etc/xen# netstat -a|grep 590
tcp        0      0 *:5901                  *:*                     LISTEN     

Boris


--- On Tue, 4/14/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "xen-devel" <xen-devel@lists.xensource.com>
Date: Tuesday, April 14, 2009, 5:27 AM

Hi all,
this patch fixes a memory corruption in blkfront that happens every time
we pass a sector aligned buffer (instead of a page aligned buffer) to
blkfront_aio.
To trigger the COW we have to write at least a byte to each page of the
buffer, but we must be careful not to overwrite useful content.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

diff -r dbc4014882d0 extras/mini-os/blkfront.c
--- a/extras/mini-os/blkfront.c	Wed Apr 01 08:36:21 2009 +0100
+++ b/extras/mini-os/blkfront.c	Tue Apr 14 10:18:30 2009 +0100
@@ -317,19 +317,21 @@
     req->sector_number = aiocbp->aio_offset / dev->info.sector_size;
 
     for (j = 0; j < n; j++) {
+        req->seg[j].first_sect = 0;
+        req->seg[j].last_sect = PAGE_SIZE / dev->info.sector_size - 1;
+    }
+    req->seg[0].first_sect = ((uintptr_t)aiocbp->aio_buf &
~PAGE_MASK) / dev->info.sector_size;
+    req->seg[n-1].last_sect = (((uintptr_t)aiocbp->aio_buf +
aiocbp->aio_nbytes - 1) & ~PAGE_MASK) / dev->info.sector_size;
+    for (j = 0; j < n; j++) {
 	uintptr_t data = start + j * PAGE_SIZE;
         if (!write) {
             /* Trigger CoW if needed */
-            *(char*)data = 0;
+            *(char*)(data + (req->seg[j].first_sect << 9)) = 0;
             barrier();
         }
 	aiocbp->gref[j] = req->seg[j].gref =
             gnttab_grant_access(dev->dom, virtual_to_mfn(data), write);
-	req->seg[j].first_sect = 0;
-	req->seg[j].last_sect = PAGE_SIZE / dev->info.sector_size - 1;
     }
-    req->seg[0].first_sect = ((uintptr_t)aiocbp->aio_buf &
~PAGE_MASK) / dev->info.sector_size;
-    req->seg[n-1].last_sect = (((uintptr_t)aiocbp->aio_buf +
aiocbp->aio_nbytes - 1) & ~PAGE_MASK) / dev->info.sector_size;
 
     dev->ring.req_prod_pvt = i + 1;
 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

[-- Attachment #1.2: Type: text/html, Size: 4260 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] fix stubdom memory corruption

[Stefano Stabellini]

Boris Derzhavets wrote:

> This one and vl.c patch have been applied.
> stubdom has been rebuilt and reinstalled.
> No improvement.

Are you sure you correctly build the new code and running fs-backend?
I am only asking this because it is really easy to have this kind of
problems with stubdoms.

If your build and test environments are correct, are there any errors in
the logfiles?

Re: [PATCH] fix stubdom memory corruption

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 935 bytes --]

After patching i did:-

# cd /usr/src/xen-unstable.hg/stubdom
# make
# make install

I haven't rebuilt tools.
Started fs-backend in separate session as usual and tried to start stub domain

Boris

--- On Tue, 4/14/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Tuesday, April 14, 2009, 8:55 AM

Boris Derzhavets wrote:

> This one and vl.c patch have been applied.
> stubdom has been rebuilt and reinstalled.
> No improvement.

Are you sure you correctly build the new code and running fs-backend?
I am only asking this because it is really easy to have this kind of
problems with stubdoms.

If your build and test environments are correct, are there any errors in
the logfiles?



      

[-- Attachment #1.2: Type: text/html, Size: 1315 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] fix stubdom memory corruption

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 3871 bytes --]

root@ServerXen331:/etc/xen# xm list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                   0  7019     2     r-----    702.0
RHELhvm                                   7  1024     1     ------      0.0

************************
Three logs generated
************************

root@ServerXen331:/var/log/xen# cat qemu-dm-RHELhvm-dm.log
domid: 9
Warning: vlan 0 is not connected to host network
Watching /local/domain/0/device-model/9/logdirty/next-active
Watching /local/domain/0/device-model/9/command
char device redirected to /dev/pts/3
/usr/src/xen-unstable.hg/tools/ioemu-dir/hw/xen_blktap.c:628: Init blktap pipes
xs_read(): vncpasswd get error. /vm/3f8762a5-b806-dca4-6442-0dfeb7da0917/vncpasswd.
medium change watch on `hdc' (index: 0): /dev/loop0
root@ServerXen331:/var/log/xen# cat qemu-dm-RHELhvm-dm.log.1
domid: 8
Warning: vlan 0 is not connected to host network
Watching /local/domain/0/device-model/8/logdirty/next-active
Watching /local/domain/0/device-model/8/command
char device redirected to /dev/pts/3
/usr/src/xen-unstable.hg/tools/ioemu-dir/hw/xen_blktap.c:628: Init blktap pipes
xs_read(): vncpasswd get error. /vm/3f8762a5-b806-dca4-6442-0dfeb7da0917/vncpasswd.
medium change watch on `hdc' (index: 0): /dev/loop0
root@ServerXen331:/var/log/xen# cat  qemu-dm-RHELhvm.log
Using config file "/etc/xen/RHELhvm-dm".
Started domain RHELhvm-dm (id=8)
Using config file "/etc/xen/RHELhvm-dm".
Unexpected error: <type 'exceptions.OSError'>

Please report to xen-devel@lists.xensource.com
Traceback (most recent call last):
  File "/usr/sbin/xm", line 7, in <module>
    main.main(sys.argv)
  File "usr/lib/python2.5/site-packages/xen/xm/main.py", line 2980, in main
    _, rc = _run_cmd(cmd, cmd_name, args)
  File "usr/lib/python2.5/site-packages/xen/xm/main.py", line 3004, in _run_cmd
    return True, cmd(args)
  File "<string>", line 1, in <lambda>
  File "usr/lib/python2.5/site-packages/xen/xm/main.py", line 1360, in xm_importcommand
    cmd.main([command] + args)
  File "usr/lib/python2.5/site-packages/xen/xm/create.py", line 1370, in main
    do_console(sxp.child_value(config, 'name', -1))
  File "usr/lib/python2.5/site-packages/xen/xm/create.py", line 1397, in do_console
    (p, rv) = os.waitpid(cpid, os.WNOHANG)
OSError: [Errno 10] No child processes

Boris

--- On Tue, 4/14/09, Boris Derzhavets <bderzhavets@yahoo.com> wrote:
From: Boris Derzhavets <bderzhavets@yahoo.com>
Subject: Re: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Tuesday, April 14, 2009, 9:01 AM

After patching i did:-

# cd /usr/src/xen-unstable.hg/stubdom
# make
# make install

I haven't rebuilt tools.
Started fs-backend in separate session as usual and tried to start stub domain

Boris

--- On Tue, 4/14/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Tuesday, April 14, 2009, 8:55 AM

Boris Derzhavets wrote:

> This one and vl.c patch have been applied.
> stubdom has been rebuilt and reinstalled.
>
 No improvement.

Are you sure you correctly build the new code and running fs-backend?
I am only asking this because it is really easy to have this kind of
problems with stubdoms.

If your build and test environments are correct, are there any errors in
the logfiles?





      _______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

[-- Attachment #1.2: Type: text/html, Size: 5723 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] fix stubdom memory corruption

[Stefano Stabellini]

Boris Derzhavets wrote:

> root@ServerXen331:/etc/xen# xm list
> Name                                        ID   Mem VCPUs      State  
> Time(s)
> Domain-0                                   0  7019     2     r-----    702.0
> RHELhvm                                   7  1024     1     ------      0.0
> 
> ************************
> Three logs generated
> ************************
> 
> root@ServerXen331:/var/log/xen# cat qemu-dm-RHELhvm-dm.log
> domid: 9
> Warning: vlan 0 is not connected to host network
> Watching /local/domain/0/device-model/9/logdirty/next-active
> Watching /local/domain/0/device-model/9/command
> char device redirected to /dev/pts/3
> /usr/src/xen-unstable.hg/tools/ioemu-dir/hw/xen_blktap.c:628: Init
> blktap pipes
> xs_read(): vncpasswd get error.
> /vm/3f8762a5-b806-dca4-6442-0dfeb7da0917/vncpasswd.
> medium change watch on `hdc' (index: 0): /dev/loop0
> root@ServerXen331:/var/log/xen# cat qemu-dm-RHELhvm-dm.log.1
> domid: 8
> Warning: vlan 0 is not connected to host network
> Watching /local/domain/0/device-model/8/logdirty/next-active
> Watching /local/domain/0/device-model/8/command
> char device redirected to /dev/pts/3
> /usr/src/xen-unstable.hg/tools/ioemu-dir/hw/xen_blktap.c:628: Init
> blktap pipes
> xs_read(): vncpasswd get error.
> /vm/3f8762a5-b806-dca4-6442-0dfeb7da0917/vncpasswd.
> medium change watch on `hdc' (index: 0): /dev/loop0
> root@ServerXen331:/var/log/xen# cat  qemu-dm-RHELhvm.log
> Using config file "/etc/xen/RHELhvm-dm".
> Started domain RHELhvm-dm (id=8)
> Using config file "/etc/xen/RHELhvm-dm".
> Unexpected error: <type 'exceptions.OSError'>
> 
> Please report to xen-devel@lists.xensource.com
> Traceback (most recent call last):
>   File "/usr/sbin/xm", line 7, in <module>
>     main.main(sys.argv)
>   File "usr/lib/python2.5/site-packages/xen/xm/main.py", line 2980, in main
>     _, rc = _run_cmd(cmd, cmd_name, args)
>   File "usr/lib/python2.5/site-packages/xen/xm/main.py", line 3004, in
> _run_cmd
>     return True, cmd(args)
>   File "<string>", line 1, in <lambda>
>   File "usr/lib/python2.5/site-packages/xen/xm/main.py", line 1360, in
> xm_importcommand
>     cmd.main([command] + args)
>   File "usr/lib/python2.5/site-packages/xen/xm/create.py", line 1370, in
> main
>     do_console(sxp.child_value(config, 'name', -1))
>   File "usr/lib/python2.5/site-packages/xen/xm/create.py", line 1397, in
> do_console
>     (p, rv) = os.waitpid(cpid, os.WNOHANG)
> OSError: [Errno 10] No child processes

If this is the only error you get, it seems to be unrelated to stubdoms.
Could you please try to start a stubdom without autoconnect (no -c)?

Re: [PATCH] fix stubdom memory corruption

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 3987 bytes --]

>if this is the only error you get, it seems to be unrelated to stubdoms.
Yes

>Could you please try to start a stubdom without autoconnect (no -c)?

Sorry , what means "-c" ?
After fs-backend start i run in different terminal session :-

xm create RHELhvm-stubdom
vncviewer localhost:0

Maybe i follow outdated instructions.
Files RHELhvm-stubdom, RHELhvm-dm are located under /etc/xen

[root@ServerXen xen]# cat RHELhvm-stubdom
kernel = "/usr/lib/xen/boot/hvmloader"
builder='hvm'
memory =1024
name = "RHELhvm"
vif = [ 'type=ioemu, bridge=eth0' ]
device_model = "/usr/lib/xen/bin/stubdom-dm"
boot="d"
sdl=0
opengl=0
vnc=0
stdvga=0

[root@ServerXen xen]# cat RHELhvm-dm
kernel = "/usr/lib/xen/boot/ioemu-stubdom.gz"
vif = [ ' ', 'bridge=eth0']
# vfb = [ 'type=sdl' ]
vfb = [ 'type=vnc' ]
disk = ['phy:/dev/loop0,hdc:cdrom,r','phy:/dev/sdb8,hda,w']

Boris.

--- On Wed, 4/15/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Wednesday, April 15, 2009, 9:37 AM

Boris Derzhavets wrote:

> root@ServerXen331:/etc/xen# xm list
> Name                                        ID   Mem VCPUs      State  
> Time(s)
> Domain-0                                   0  7019     2     r-----   
702.0
> RHELhvm                                   7  1024     1     ------     
0.0
> 
> ************************
> Three logs generated
> ************************
> 
> root@ServerXen331:/var/log/xen# cat qemu-dm-RHELhvm-dm.log
> domid: 9
> Warning: vlan 0 is not connected to host network
> Watching /local/domain/0/device-model/9/logdirty/next-active
> Watching /local/domain/0/device-model/9/command
> char device redirected to /dev/pts/3
> /usr/src/xen-unstable.hg/tools/ioemu-dir/hw/xen_blktap.c:628: Init
> blktap pipes
> xs_read(): vncpasswd get error.
> /vm/3f8762a5-b806-dca4-6442-0dfeb7da0917/vncpasswd.
> medium change watch on `hdc' (index: 0): /dev/loop0
> root@ServerXen331:/var/log/xen# cat qemu-dm-RHELhvm-dm.log.1
> domid: 8
> Warning: vlan 0 is not connected to host network
> Watching /local/domain/0/device-model/8/logdirty/next-active
> Watching /local/domain/0/device-model/8/command
> char device redirected to /dev/pts/3
> /usr/src/xen-unstable.hg/tools/ioemu-dir/hw/xen_blktap.c:628: Init
> blktap pipes
> xs_read(): vncpasswd get error.
> /vm/3f8762a5-b806-dca4-6442-0dfeb7da0917/vncpasswd.
> medium change watch on `hdc' (index: 0): /dev/loop0
> root@ServerXen331:/var/log/xen# cat  qemu-dm-RHELhvm.log
> Using config file "/etc/xen/RHELhvm-dm".
> Started domain RHELhvm-dm (id=8)
> Using config file "/etc/xen/RHELhvm-dm".
> Unexpected error: <type 'exceptions.OSError'>
> 
> Please report to xen-devel@lists.xensource.com
> Traceback (most recent call last):
>   File "/usr/sbin/xm", line 7, in <module>
>     main.main(sys.argv)
>   File "usr/lib/python2.5/site-packages/xen/xm/main.py", line
2980, in main
>     _, rc = _run_cmd(cmd, cmd_name, args)
>   File "usr/lib/python2.5/site-packages/xen/xm/main.py", line
3004, in
> _run_cmd
>     return True, cmd(args)
>   File "<string>", line 1, in <lambda>
>   File "usr/lib/python2.5/site-packages/xen/xm/main.py", line
1360, in
> xm_importcommand
>     cmd.main([command] + args)
>   File "usr/lib/python2.5/site-packages/xen/xm/create.py", line
1370, in
> main
>     do_console(sxp.child_value(config, 'name', -1))
>   File "usr/lib/python2.5/site-packages/xen/xm/create.py", line
1397, in
> do_console
>     (p, rv) = os.waitpid(cpid, os.WNOHANG)
> OSError: [Errno 10] No child processes

If this is the only error you get, it seems to be unrelated to stubdoms.
Could you please try to start a stubdom without autoconnect (no -c)?


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

[-- Attachment #1.2: Type: text/html, Size: 4838 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] fix stubdom memory corruption

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 799 bytes --]

Xen unstable 3.4-rc2-pre had been installed earlier

Boris.

--- On Tue, 4/14/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Tuesday, April 14, 2009, 8:55 AM

Boris Derzhavets wrote:

> This one and vl.c patch have been applied.
> stubdom has been rebuilt and reinstalled.
> No improvement.

Are you sure you correctly build the new code and running fs-backend?
I am only asking this because it is really easy to have this kind of
problems with stubdoms.

If your build and test environments are correct, are there any errors in
the logfiles?



      

[-- Attachment #1.2: Type: text/html, Size: 1158 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] fix stubdom memory corruption

[Stefano Stabellini]

Boris Derzhavets wrote:

> Xen unstable 3.4-rc2-pre had been installed earlier
> 

I think it may be worth to do a clean build and try again, because I can
confirm that with my previous patches stubdoms work for me on xen and
qemu tip.

Re: [PATCH] fix stubdom memory corruption

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 802 bytes --]

I believe you worked with 2.6.18.8-xen kernel in Dom0.

Thanks.
Boris.

--- On Tue, 4/14/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Tuesday, April 14, 2009, 11:33 AM

Boris Derzhavets wrote:

> Xen unstable 3.4-rc2-pre had been installed earlier
> 

I think it may be worth to do a clean build and try again, because I can
confirm that with my previous patches stubdoms work for me on xen and
qemu tip.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

[-- Attachment #1.2: Type: text/html, Size: 1162 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] fix stubdom memory corruption

[Stefano Stabellini]

Boris Derzhavets wrote:

> I believe you worked with 2.6.18.8-xen kernel in Dom0.
> 

Yes, I'll try with a different kernel.

Re: [PATCH] fix stubdom memory corruption

[Boris Derzhavets]

[-- Attachment #1.1: Type: text/plain, Size: 1268 bytes --]

I had rebuilt Xen 3.4-rc2-pre from scratch.

Building Xen after fresh clone xen-unstable.hg :-

# make xen
# make tools
# make uninstall
# make install-xen
# make install-tools
# cd stubdom
# make
# make install

then tried Suse's 2.6.27.5 and 2.6.30-rc1-tip  under Xen 3.4-rc2-pre.
Same error in logs:-
    /usr/src/xen-unstable.hg/tools/ioemu-dir/hw/xen_blktap.c:628: Init blktap pipes
I guess pvops kernel is just missing blktap support
I need to check "make menuconfig" for Suse's one.

fs-backend is absolutly irresponsive with pvops kernel and seems to work as
usual with 2.6.27.5
Thanks.
Boris.

--- On Wed, 4/15/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fix stubdom memory corruption
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Wednesday, April 15, 2009, 5:14 AM

Boris Derzhavets wrote:

> I believe you worked with 2.6.18.8-xen kernel in Dom0.
> 

Yes, I'll try with a different kernel.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

[-- Attachment #1.2: Type: text/html, Size: 1650 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] fix stubdom memory corruption

[Pasi Kärkkäinen]

On Wed, Apr 15, 2009 at 04:21:35AM -0700, Boris Derzhavets wrote:
> I had rebuilt Xen 3.4-rc2-pre from scratch.
> 
> Building Xen after fresh clone xen-unstable.hg :-
> 
> # make xen
> # make tools
> # make uninstall
> # make install-xen
> # make install-tools
> # cd stubdom
> # make
> # make install
> 
> then tried Suse's 2.6.27.5 and 2.6.30-rc1-tip  under Xen 3.4-rc2-pre.
> Same error in logs:-
>     /usr/src/xen-unstable.hg/tools/ioemu-dir/hw/xen_blktap.c:628: Init blktap pipes
> I guess pvops kernel is just missing blktap support
>

Yep, pv_ops dom0 kernel is still missing blktap support.. 
Citrix blktap2 will be merged later to pv_ops dom0 kernel, iirc.

> 
> fs-backend is absolutly irresponsive with pvops kernel and seems to work as
> usual with 2.6.27.5

I've been using phy: LVM-volumes successfully with pv_ops dom0 kernel.

-- Pasi