All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Netfilter Development Mailinglist
	<netfilter-devel@vger.kernel.org>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: panic on rmmod of nf_conntrack_irc
Date: Wed, 15 Apr 2009 12:42:27 +0200	[thread overview]
Message-ID: <49E5BA13.7000501@cosmosbay.com> (raw)
In-Reply-To: <49E5B66D.30602@trash.net>

Patrick McHardy a écrit :
> Eric Dumazet wrote:
>> I should have used different fields names (from "next", "first", ...)
>> to catch this
>> kind of errors at compile time :(
>>
>> Something like :
>>
>> diff --git a/include/linux/list_nulls.h b/include/linux/list_nulls.h
> 
> Eric, on second thought, could you please resubmit this to Dave?
> It touches too many files outside of netfilter to go through my
> tree.
> 
> 

Sure, but its a cleanup (and was an RFC to show my point)
so should wait a litle bit until David opens his -next tree (for 2.6.31)

Please just submit your patch for 2.6.30 ?


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <dada1@cosmosbay.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Netfilter Development Mailinglist 
	<netfilter-devel@vger.kernel.org>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: panic on rmmod of nf_conntrack_irc
Date: Wed, 15 Apr 2009 12:42:27 +0200	[thread overview]
Message-ID: <49E5BA13.7000501@cosmosbay.com> (raw)
In-Reply-To: <49E5B66D.30602@trash.net>

Patrick McHardy a écrit :
> Eric Dumazet wrote:
>> I should have used different fields names (from "next", "first", ...)
>> to catch this
>> kind of errors at compile time :(
>>
>> Something like :
>>
>> diff --git a/include/linux/list_nulls.h b/include/linux/list_nulls.h
> 
> Eric, on second thought, could you please resubmit this to Dave?
> It touches too many files outside of netfilter to go through my
> tree.
> 
> 

Sure, but its a cleanup (and was an RFC to show my point)
so should wait a litle bit until David opens his -next tree (for 2.6.31)

Please just submit your patch for 2.6.30 ?



  reply	other threads:[~2009-04-15 10:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090410191736.21efab8c@mako-desktop>
2009-04-14 11:32 ` panic on rmmod of nf_conntrack_irc Patrick McHardy
2009-04-14 11:32   ` Patrick McHardy
2009-04-14 12:06   ` Eric Dumazet
2009-04-14 12:16     ` Patrick McHardy
2009-04-14 12:16       ` Patrick McHardy
2009-04-14 19:19       ` Mariusz Kozlowski
2009-04-14 19:19         ` Mariusz Kozlowski
2009-04-14 19:19         ` Mariusz Kozlowski
2009-04-14 20:06         ` Mariusz Kozlowski
2009-04-14 20:06           ` Mariusz Kozlowski
2009-04-14 20:06           ` Mariusz Kozlowski
2009-04-14 20:14         ` Eric Dumazet
2009-04-14 20:14           ` Eric Dumazet
2009-04-14 20:39           ` Mariusz Kozlowski
2009-04-14 20:39             ` Mariusz Kozlowski
2009-04-14 20:46           ` Eric Leblond
2009-04-14 21:07             ` [PATCH] netfilter: nf_log fix Eric Dumazet
2009-04-15 10:20               ` Patrick McHardy
     [not found]     ` <49E47C2D.1050508-fPLkHRcR87vqlBn2x/YWAg@public.gmane.org>
2009-04-15 10:26       ` panic on rmmod of nf_conntrack_irc Patrick McHardy
2009-04-15 10:26         ` Patrick McHardy
2009-04-15 10:42         ` Eric Dumazet [this message]
2009-04-15 10:42           ` Eric Dumazet
2009-04-15 10:44           ` Patrick McHardy
2009-04-15 10:45           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E5BA13.7000501@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=kaber@trash.net \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.kozlowski@tuxland.pl \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.