Re: [PATCH 1/2] Make BIOS irq0->inti2 override configurable from userspace

[Avi Kivity <avi@redhat.com>]

Beth Kon wrote:
> These patches resolve the irq0->inti2 override issue, and get the hpet working
> on kvm with and without -no-kvm-irqchip (i.e., when hpet takes over, it 
> disables userspace or in-kernel pit as appropriate).
>
> The irq0->inti2 override will always be used unless the kernel cannot do irq 
> routing (i.e., compatibility with old kernels). So if the kernel is capable, 
> userspace sets up irq0->inti2 via the irq routing interface, and adds the 
> irq0->inti2 override to the MADT interrupt source override table, 
> and the mp table (for the no-acpi case).
>
> A couple of months ago, Marcelo was seeing RHEL5 guests complain of invalid
> checksum with these patches, but later he couldn't reproduce it, and I'm not 
> seeing it now. While all guests still need to be fully tested, everything 
> appears to be in order.  I've tested on win2k864, win2k832, RHEL5.3 32 bit, 
> and ubuntu 8.10 64 bit. 
>   

Both patches look good.  However, the bios in kvm-userspace.git is 
pretty old.  To ease later merging, I'd like to update the bios first, 
so please rebase the patches once I've done that.  It will take a few 
days since large merges are blocked while I struggle to get a working 
kvm-85 out.

Please also separate the bios patches from qemu patches.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.