From: Or Gerlitz <ogerlitz@Voltaire.com>
To: Jay Vosburgh <fubar@us.ibm.com>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: zero features for a vlan over bond / vlan features
Date: Thu, 16 Apr 2009 17:11:32 +0300 [thread overview]
Message-ID: <49E73C94.5030009@Voltaire.com> (raw)
In-Reply-To: <6223.1239113811@death.nxdomain.ibm.com>
Jay Vosburgh wrote:
> The features system now has a dev->vlan_features that lists the
> features that will work through a vlan; bond_compute_features isn't
> using netdev_increment/fix_features to additionally compute the vlan_features,
> so that's ending up always empty even if the underlying device supports vlan passthrough.
> I'm working on a patch; I'll see what I can come up with.
Great, I will be happy to test the patch once you have it...
> Note, however, that at this writing, the set of drivers that explicitly
> supports VLAN passthrough (a non-zero vlan_features) is rather limited.
Please correct me if I'm wrong - would be it correct to say that there's a concept
of "VLAN acceleration" which comes into play when the NIC device advertises
NETIF_F_HW_VLAN_xxx features and a concept of "VLAN passthrough" which means the
NIC device have a non empty vlan_features bit mask?
Looking on Linus tree I noted that indeed only few drivers have non-empty vlan_features
and I wonder if the reason for that is indeed lack of HW support or just the driver
maintainers being somehow slow to catch up with the vlan_features concept, Dave -
any insight here?
Or.
next prev parent reply other threads:[~2009-04-16 14:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 13:00 zero features for a vlan over bond Or Gerlitz
2009-04-07 14:16 ` Jay Vosburgh
2009-04-07 22:16 ` Or Gerlitz
2009-04-16 14:11 ` Or Gerlitz [this message]
2009-04-23 23:47 ` zero features for a vlan over bond / vlan features Jay Vosburgh
2009-06-08 9:34 ` Or Gerlitz
2009-07-20 8:08 ` Or Gerlitz
2009-07-22 21:34 ` [PATCH net-next-2.6] bonding: propogate vlan_features to bonding master Jay Vosburgh
2009-07-23 6:03 ` Eric Dumazet
2009-07-23 7:24 ` Or Gerlitz
2009-07-23 8:29 ` [PATCH net-next-2.6] bnx2: Update vlan_features Eric Dumazet
2009-07-23 12:01 ` Eric Dumazet
2009-07-23 17:59 ` David Miller
2009-07-24 0:12 ` Michael Chan
2009-07-24 7:21 ` [PATCH net-next-2.6] bnx2x: Dont update vlan_features in bnx2x_set_tso() Eric Dumazet
2009-07-26 10:53 ` Eilon Greenstein
2009-07-27 2:49 ` David Miller
2009-07-27 2:50 ` [PATCH net-next-2.6] bnx2: Update vlan_features David Miller
2009-07-23 11:03 ` [PATCH net-next-2.6] bonding: propogate vlan_features to bonding master Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E73C94.5030009@Voltaire.com \
--to=ogerlitz@voltaire.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.