[PATCH] Supply uclibc-thread-db package expected by task-sdk-base

[PATCH] Supply uclibc-thread-db package expected by task-sdk-base

[David Huggins-Daines]

Currently, building task-sdk-base (and by extension meta-toolchain) fails
for uclibc targets.  This is because task-sdk-base depends on the thread
debugging library uclibc-thread-db, but this is not built by the uclibc
recipe unless PTHREADS_DEBUG_SUPPORT is enabled.  In addition, once it is
built, if you are using Debian version numbers, it will be helpfully
renamed to "libthread-db1" and the build will still fail.

This patch fixes these problems, it's against stable/2009 but will also
apply to .dev

---
 recipes/uclibc/uclibc-0.9.30/uClibc.distro |    2 +-
 recipes/uclibc/uclibc.inc                  |    3 +++
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/recipes/uclibc/uclibc-0.9.30/uClibc.distro b/recipes/uclibc/uclibc-0.9.30/uClibc.distro
index b072b2f..d8eed91 100644
--- a/recipes/uclibc/uclibc-0.9.30/uClibc.distro
+++ b/recipes/uclibc/uclibc-0.9.30/uClibc.distro
@@ -17,7 +17,7 @@ UCLIBC_CTOR_DTOR=y
 LDSO_GNU_HASH_SUPPORT=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 LINUXTHREADS_OLD=y
 UCLIBC_HAS_LFS=y
 # MALLOC is not set
diff --git a/recipes/uclibc/uclibc.inc b/recipes/uclibc/uclibc.inc
index be085ab..46d36d2 100644
--- a/recipes/uclibc/uclibc.inc
+++ b/recipes/uclibc/uclibc.inc
@@ -55,6 +55,9 @@ FILES_uclibc-gconv = "${libdir}/gconv"
 FILES_uclibc-thread-db = "/lib/libthread_db*"
 RPROVIDES_uclibc-dev += "libc-dev virtual-libc-dev"
 
+# uclibc-thread-db will get renamed to libthread-db1, which we do not want
+DEBIANNAME_uclibc-thread-db = "uclibc-thread-db"
+
 #
 # This locale file gets copied into uClibc-${PV}/extra/locale/ prior to
 # build, it does not need to be unpacked, but we can't inhibit the unpacking
-- 
1.5.6.3

Re: [PATCH] Supply uclibc-thread-db package expected by task-sdk-base

[Koen Kooi]

On 14-04-09 22:05, David Huggins-Daines wrote:
> Currently, building task-sdk-base (and by extension meta-toolchain) fails
> for uclibc targets.  This is because task-sdk-base depends on the thread
> debugging library uclibc-thread-db, but this is not built by the uclibc
> recipe unless PTHREADS_DEBUG_SUPPORT is enabled.  In addition, once it is
> built, if you are using Debian version numbers, it will be helpfully
> renamed to "libthread-db1" and the build will still fail.

> +# uclibc-thread-db will get renamed to libthread-db1, which we do not want
> +DEBIANNAME_uclibc-thread-db = "uclibc-thread-db"

Actually we *do* want the rename, and OE is perfectly capable of 
including a renamed package in a task.

regards,

Koen

Re: [PATCH] Supply uclibc-thread-db package expected by task-sdk-base

[Tom Rini]

On Tue, Apr 14, 2009 at 04:05:18PM -0400, David Huggins-Daines wrote:

> Currently, building task-sdk-base (and by extension meta-toolchain) fails
> for uclibc targets.  This is because task-sdk-base depends on the thread
> debugging library uclibc-thread-db, but this is not built by the uclibc
> recipe unless PTHREADS_DEBUG_SUPPORT is enabled.  In addition, once it is
> built, if you are using Debian version numbers, it will be helpfully
> renamed to "libthread-db1" and the build will still fail.
> 
> This patch fixes these problems, it's against stable/2009 but will also
> apply to .dev

That's interesting as when I pushed these changes I did test with a
uclibc target too.  What DISTRO/MACHINE are you using?

-- 
Tom Rini

Re: [PATCH] Supply uclibc-thread-db package expected by task-sdk-base

[David Huggins-Daines]

Tom Rini wrote:
> On Tue, Apr 14, 2009 at 04:05:18PM -0400, David Huggins-Daines wrote:
>
>   
>> Currently, building task-sdk-base (and by extension meta-toolchain) fails
>> for uclibc targets.  This is because task-sdk-base depends on the thread
>> debugging library uclibc-thread-db, but this is not built by the uclibc
>> recipe unless PTHREADS_DEBUG_SUPPORT is enabled.  In addition, once it is
>> built, if you are using Debian version numbers, it will be helpfully
>> renamed to "libthread-db1" and the build will still fail.
>>
>>     
As pointed out earlier on this thread (and verified - there was some
confusion on my part since I didn't fully clean before rebuilding), the
library renaming itself doesn't cause any problems.  The only actual
problem is the lack of PTHREADS_DEBUG_SUPPORT.
> That's interesting as when I pushed these changes I did test with a
> uclibc target too.  What DISTRO/MACHINE are you using?
>   
I have a custom distro and machine, but broadly speaking it is
minimal-uclibc and ep93xx...

Re: [PATCH] Supply uclibc-thread-db package expected by task-sdk-base

[Tom Rini]

On Thu, Apr 16, 2009 at 01:00:02PM -0400, David Huggins-Daines wrote:
> Tom Rini wrote:
> > On Tue, Apr 14, 2009 at 04:05:18PM -0400, David Huggins-Daines wrote:
> >
> >   
> >> Currently, building task-sdk-base (and by extension meta-toolchain) fails
> >> for uclibc targets.  This is because task-sdk-base depends on the thread
> >> debugging library uclibc-thread-db, but this is not built by the uclibc
> >> recipe unless PTHREADS_DEBUG_SUPPORT is enabled.  In addition, once it is
> >> built, if you are using Debian version numbers, it will be helpfully
> >> renamed to "libthread-db1" and the build will still fail.
> >>
> >>     
> As pointed out earlier on this thread (and verified - there was some
> confusion on my part since I didn't fully clean before rebuilding), the
> library renaming itself doesn't cause any problems.  The only actual
> problem is the lack of PTHREADS_DEBUG_SUPPORT.
> > That's interesting as when I pushed these changes I did test with a
> > uclibc target too.  What DISTRO/MACHINE are you using?
> >   
> I have a custom distro and machine, but broadly speaking it is
> minimal-uclibc and ep93xx...

OK, that's what I was wondering.  Khem, do we think
PTHREADS_DEBUG_SUPPORT should get enabled globally?  If so, then we
should go and audit all of the distro uClibc.distro files and get this
fixed for everybody.  Thanks.

-- 
Tom Rini

Re: [PATCH] Supply uclibc-thread-db package expected by task-sdk-base

[Khem Raj]

On (16/04/09 10:11), Tom Rini wrote:
> On Thu, Apr 16, 2009 at 01:00:02PM -0400, David Huggins-Daines wrote:
> > Tom Rini wrote:
> > > On Tue, Apr 14, 2009 at 04:05:18PM -0400, David Huggins-Daines wrote:
> > >
> > >   
> > >> Currently, building task-sdk-base (and by extension meta-toolchain) fails
> > >> for uclibc targets.  This is because task-sdk-base depends on the thread
> > >> debugging library uclibc-thread-db, but this is not built by the uclibc
> > >> recipe unless PTHREADS_DEBUG_SUPPORT is enabled.  In addition, once it is
> > >> built, if you are using Debian version numbers, it will be helpfully
> > >> renamed to "libthread-db1" and the build will still fail.
> > >>
> > >>     
> > As pointed out earlier on this thread (and verified - there was some
> > confusion on my part since I didn't fully clean before rebuilding), the
> > library renaming itself doesn't cause any problems.  The only actual
> > problem is the lack of PTHREADS_DEBUG_SUPPORT.
> > > That's interesting as when I pushed these changes I did test with a
> > > uclibc target too.  What DISTRO/MACHINE are you using?
> > >   
> > I have a custom distro and machine, but broadly speaking it is
> > minimal-uclibc and ep93xx...
> 
> OK, that's what I was wondering.  Khem, do we think
> PTHREADS_DEBUG_SUPPORT should get enabled globally?  If so, then we
> should go and audit all of the distro uClibc.distro files and get this
> fixed for everybody.  Thanks.

yes I think it is needed for debugging threads so we have to enable it.
right we need to put it in all config files. I will take a look.

> 
> -- 
> Tom Rini
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel