[PATCH] update canadian-sdk to match meta-toolchain

[PATCH] update canadian-sdk to match meta-toolchain

[David Huggins-Daines]

This patch synchronizes (to some extent) canadian-sdk.bb with
meta-toolchain.bb.  Unlike meta-toolchain, it does not build an
-extras package.  There's a lot of code duplication there which I will
leave to the experts to sort out :)

---
 recipes/meta/canadian-sdk.bb |  130 ++++++++++++++++++++++++++----------------
 1 files changed, 81 insertions(+), 49 deletions(-)

diff --git a/recipes/meta/canadian-sdk.bb b/recipes/meta/canadian-sdk.bb
index 150c752..1584b9f 100644
--- a/recipes/meta/canadian-sdk.bb
+++ b/recipes/meta/canadian-sdk.bb
@@ -1,25 +1,57 @@
 DESCRIPTION = "Meta package for building a installable toolchain"
 LICENSE = "MIT"
-DEPENDS = "ipkg-native ipkg-utils-native fakeroot-native sed-native zip-native"
-PR = "r2"
+DEPENDS = "opkg-native ipkg-utils-native fakeroot-native sed-native zip-native"
+PR = "r3"
+
+# NOTE: We need to save and restore PACKAGE_ARCHS, because sdk.bbclass
+# will change HOST_ARCH, which can result in SITEINFO_ENDIANESS (which
+# is computed in siteinfo.bbclass) in changing if the original HOST_ARCH
+# endianess differs from the new HOST_ARCH endianess.  SITEINFO_ENDIANNESS
+# is used in a number of places, including the construction of the
+# PACKAGE_EXTRA_ARCHS list for machines that are capable of running in
+# either endianess.  There may be better ways to fix this.
+
+# Save value of PACKAGE_ARCHS (note the ":=" syntax to force immediate eval)
+REAL_PACKAGE_ARCHS := "${PACKAGE_ARCHS}"
 
 inherit canadian-sdk meta
 
+# Restore PACKAGE_ARCHS (sdk.bbclass may have caused it to change)
+PACKAGE_ARCHS := "${REAL_PACKAGE_ARCHS}"
+
 SDK_DIR = "${WORKDIR}/sdk"
 SDK_OUTPUT = "${SDK_DIR}/image"
-SDK_DEPLOY = "${TMPDIR}/deploy/sdk"
-SDK_SUFFIX = "toolchain"
+SDK_DEPLOY = "${DEPLOY_DIR}/sdk"
 
-FEED_ARCH ?= "${TARGET_ARCH}"
-
-IPKG_HOST = "ipkg-cl -f ${IPKGCONF_CANSDK} -o ${SDK_OUTPUT}"
-IPKG_TARGET = "ipkg-cl -f ${IPKGCONF_TARGET} -o ${SDK_OUTPUT}${prefix}"
+IPKG_HOST = "opkg-cl -f ${IPKGCONF_CANSDK} -o ${SDK_OUTPUT}"
+IPKG_TARGET = "opkg-cl -f ${IPKGCONF_TARGET} -o ${SDK_OUTPUT}/${SDK_PATH}/${TARGET_SYS}"
 
 TOOLCHAIN_CANADIAN_HOST_TASK ?= "task-sdk-canadian-host"
 TOOLCHAIN_TARGET_TASK ?= "task-sdk-bare"
+FEED_ARCH ?= "${TARGET_ARCH}"
+SDK_SUFFIX = "toolchain"
+TOOLCHAIN_OUTPUTNAME ?= "${SDK_SYS}-${DISTRO}-${DISTRO_VERSION}-${FEED_ARCH}-${TARGET_OS}-${SDK_SUFFIX}"
 
 RDEPENDS = "${TOOLCHAIN_TARGET_TASK} ${TOOLCHAIN_CANADIAN_HOST_TASK}"
 
+TOOLCHAIN_FEED_URI ?= "${DISTRO_FEED_URI}"
+
+modify_opkg_conf () {
+        OUTPUT_OPKGCONF_TARGET="${SDK_OUTPUT}/${prefix}/${TARGET_SYS}/${layout_sysconfdir}/opkg.conf"
+        OUTPUT_OPKGCONF_HOST="${SDK_OUTPUT}/${prefix}/${TARGET_SYS}/${layout_sysconfdir}/opkg-canadian-sdk.conf"
+        OUTPUT_OPKGCONF_SDK="${SDK_OUTPUT}/${sysconfdir}/opkg-canadian-sdk.conf"
+        rm ${OUTPUT_OPKGCONF_TARGET}
+        rm ${OUTPUT_OPKGCONF_HOST}
+        rm ${OUTPUT_OPKGCONF_SDK}
+        opkgarchs="${PACKAGE_ARCHS}"
+        priority=1
+        for arch in ${opkgarchs}; do
+                echo "arch ${arch} ${priority}" >> ${OUTPUT_OPKGCONF_TARGET};
+                echo "src/gz ${arch} ${TOOLCHAIN_FEED_URI}/${arch}" >> ${OUTPUT_OPKGCONF_TARGET};
+                priority=$(expr ${priority} + 5);
+        done
+}
+
 do_populate_sdk() {
 	rm -rf ${SDK_OUTPUT}
 	mkdir -p ${SDK_OUTPUT}
@@ -31,41 +63,26 @@ do_populate_sdk() {
 		revipkgarchs="$arch $revipkgarchs"
 	done
 
+	mkdir -p ${SDK_OUTPUT}/usr/lib/opkg
 	${IPKG_HOST} update
 	${IPKG_HOST} -force-depends install ${TOOLCHAIN_CANADIAN_HOST_TASK}
 
+	mkdir -p ${SDK_OUTPUT}/${SDK_PATH}/${TARGET_SYS}/usr/lib/opkg
 	${IPKG_TARGET} update
 	${IPKG_TARGET} install ${TOOLCHAIN_TARGET_TASK}
 
-	mkdir -p ${SDK_OUTPUT}${prefix}/${TARGET_SYS}
-	cp -pPR ${SDK_OUTPUT}${prefix}/usr ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/
-	rm -rf ${SDK_OUTPUT}${prefix}/usr
-
-	cp -pPR ${SDK_OUTPUT}${prefix}/lib/* ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/
-	rm -rf ${SDK_OUTPUT}${prefix}/lib/*
-
-	cp -pPR ${SDK_OUTPUT}/usr/lib/ipkg ${SDK_OUTPUT}${prefix}/lib/
-	rm -rf ${SDK_OUTPUT}/usr/lib/ipkg/*
-	rmdir -p --ignore-fail-on-non-empty ${SDK_OUTPUT}/usr/lib/ipkg
-
-	for fn in `ls ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/`; do
-		if [ -h ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/$fn ]; then
-			link=`readlink ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/$fn`
-			bname=`basename $link`
-			if [ ! -e $link -a -e ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/$bame ]; then
-				rm ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/$fn
-				ln -s $bname ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/$fn
-			fi
-		fi
-	done
+	install -d ${SDK_OUTPUT}/${prefix}/usr/lib/opkg
+	mv ${SDK_OUTPUT}/usr/lib/opkg/* ${SDK_OUTPUT}/${prefix}/usr/lib/opkg/
+	rm -Rf ${SDK_OUTPUT}/usr/lib
 
-	mv ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/gcc ${SDK_OUTPUT}${prefix}/lib
+	install -d ${SDK_OUTPUT}/${prefix}/${TARGET_SYS}/${layout_sysconfdir}
+	install -m 0644 ${IPKGCONF_TARGET} ${IPKGCONF_CANSDK} ${SDK_OUTPUT}/${prefix}/${TARGET_SYS}/${layout_sysconfdir}/
 
-	echo 'GROUP ( libpthread.so.0 libpthread_nonshared.a )' > ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/libpthread.so
-	echo 'GROUP ( libc.so.6 libc_nonshared.a )' > ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/lib/libc.so
+	install -d ${SDK_OUTPUT}/${sysconfdir}
+	install -m 0644 ${IPKGCONF_CANSDK} ${SDK_OUTPUT}/${sysconfdir}/
 
 	# extract and store ipks, pkgdata and shlibs data
-	target_pkgs=`cat ${SDK_OUTPUT}${prefix}/${TARGET_SYS}/usr/lib/ipkg/status | grep Package: | cut -f 2 -d ' '`
+	target_pkgs=`cat ${SDK_OUTPUT}/${prefix}/package-status | grep Package: | cut -f 2 -d ' '`
 	mkdir -p ${SDK_OUTPUT}/${prefix}/ipk/
 	mkdir -p ${SDK_OUTPUT}/${prefix}/pkgdata/runtime/
 	mkdir -p ${SDK_OUTPUT}/${prefix}/${TARGET_SYS}/shlibs/
@@ -78,12 +95,12 @@ do_populate_sdk() {
 				orig_pkg=`ipkg-list-fields $pkgnames | grep OE: | cut -d ' ' -f2`
 				pkg_subdir=$arch${TARGET_VENDOR}${@['-' + bb.data.getVar('TARGET_OS', d, 1), ''][bb.data.getVar('TARGET_OS', d, 1) == ('' or 'custom')]}
 				mkdir -p ${SDK_OUTPUT}/${prefix}/pkgdata/$pkg_subdir/runtime
-				cp ${TMPDIR}/pkgdata/$pkg_subdir/$orig_pkg ${SDK_OUTPUT}/${prefix}/pkgdata/$pkg_subdir/
-				subpkgs=`cat ${TMPDIR}/pkgdata/$pkg_subdir/$orig_pkg | grep PACKAGES: | cut -b 10-`
+				cp ${STAGING_DIR}/pkgdata/$pkg_subdir/$orig_pkg ${SDK_OUTPUT}/${prefix}/pkgdata/$pkg_subdir/
+				subpkgs=`cat ${STAGING_DIR}/pkgdata/$pkg_subdir/$orig_pkg | grep PACKAGES: | cut -b 10-`
 				for subpkg in $subpkgs; do
-					cp ${TMPDIR}/pkgdata/$pkg_subdir/runtime/$subpkg ${SDK_OUTPUT}/${prefix}/pkgdata/$pkg_subdir/runtime/
-					if [ -e ${TMPDIR}/pkgdata/$pkg_subdir/runtime/$subpkg.packaged ];then
-						cp ${TMPDIR}/pkgdata/$pkg_subdir/runtime/$subpkg.packaged ${SDK_OUTPUT}/${prefix}/pkgdata/$pkg_subdir/runtime/
+					cp ${STAGING_DIR}/pkgdata/$pkg_subdir/runtime/$subpkg ${SDK_OUTPUT}/${prefix}/pkgdata/$pkg_subdir/runtime/
+					if [ -e ${STAGING_DIR}/pkgdata/$pkg_subdir/runtime/$subpkg.packaged ];then
+						cp ${STAGING_DIR}/pkgdata/$pkg_subdir/runtime/$subpkg.packaged ${SDK_OUTPUT}/${prefix}/pkgdata/$pkg_subdir/runtime/
 					fi
 					if [ -e ${STAGING_DIR_TARGET}/shlibs/$subpkg.list ]; then
 						cp ${STAGING_DIR_TARGET}/shlibs/$subpkg.* ${SDK_OUTPUT}/${prefix}/${TARGET_SYS}/shlibs/
@@ -96,7 +113,7 @@ do_populate_sdk() {
 
 	# add missing link to libgcc_s.so.1
 	# libgcc-dev should be responsible for that, but it's not getting built
-	# RP: it gets smashed up depending on the order that gcc, gcc-cross and
+	# RP: it gets smashed up depending on the order that gcc, gcc-cross and 
 	# gcc-cross-sdk get built :( (30/11/07)
 	ln -sf libgcc_s.so.1 ${SDK_OUTPUT}/${prefix}/${TARGET_SYS}/lib/libgcc_s.so
 
@@ -116,21 +133,36 @@ do_populate_sdk() {
 	for sitefile in ${CONFIG_SITE} ; do
 		cat $sitefile >> $siteconfig
 	done
-}
 
-do_package_sdk() {
-	# package it up
+	# Create environment setup script
+	script=${SDK_OUTPUT}/${prefix}/environment-setup
+	touch $script
+	echo 'export PATH=${prefix}/bin:$PATH' >> $script
+	echo 'export LIBTOOL_SYSROOT_PATH=${prefix}/${TARGET_SYS}' >> $script
+	echo 'export PKG_CONFIG_SYSROOT_DIR=${prefix}/${TARGET_SYS}' >> $script
+	echo 'export PKG_CONFIG_PATH=${prefix}/${TARGET_SYS}${layout_libdir}/pkgconfig' >> $script
+	echo 'export CONFIG_SITE=${prefix}/site-config' >> $script
+	echo "alias opkg='LD_LIBRARY_PATH=${prefix}/lib ${prefix}/bin/opkg-cl -f ${sysconfdir}/opkg-canadian-sdk.conf -o ${prefix}'" >> $script
+	echo "alias opkg-target='LD_LIBRARY_PATH=${prefix}/lib ${prefix}/bin/opkg-cl -f ${prefix}/${TARGET_SYS}${layout_sysconfdir}/opkg.conf -o ${prefix}/${TARGET_SYS}'" >> $script
+
+	# Add version information
+	versionfile=${SDK_OUTPUT}/${prefix}/version
+	touch $versionfile
+	echo 'Distro: ${DISTRO}' >> $versionfile
+	echo 'Distro Version: ${DISTRO_VERSION}' >> $versionfile
+	echo 'Metadata Revision: ${METADATA_REVISION}' >> $versionfile
+	echo 'Timestamp: ${DATETIME}' >> $versionfile
+
+	modify_opkg_conf
+
+	# Package it up
 	mkdir -p ${SDK_DEPLOY}
 	cd ${SDK_OUTPUT}
-	fakeroot tar cfj ${SDK_DEPLOY}/${SDK_SYS}-sdk-${DISTRO}-${DISTRO_VERSION}-${FEED_ARCH}-${TARGET_OS}.tar.bz2 .${prefix}
-	rm -f ${SDK_DEPLOY}/${SDK_SYS}-sdk-${DISTRO}-${DISTRO_VERSION}-${FEED_ARCH}-${TARGET_OS}.zip
-	zip -r -D ${SDK_DEPLOY}/${SDK_SYS}-sdk-${DISTRO}-${DISTRO_VERSION}-${FEED_ARCH}-${TARGET_OS}.zip .${prefix}
+	fakeroot tar cfj ${SDK_DEPLOY}/${TOOLCHAIN_OUTPUTNAME}.tar.bz2 .
+	rm -f ${SDK_DEPLOY}/${TOOLCHAIN_OUTPUTNAME}.zip
+	zip -r -D ${SDK_DEPLOY}/${TOOLCHAIN_OUTPUTNAME}.zip .
 }
 
 do_populate_sdk[nostamp] = "1"
 do_populate_sdk[recrdeptask] = "do_package_write"
 addtask populate_sdk before do_build after do_install
-
-do_package_sdk[nostamp] = "1"
-do_package_sdk[recrdeptask] = "do_populate_sdk"
-addtask package_sdk before do_build after do_populate_sdk
-- 
1.5.6.3

[PATCH] fix do_install for MinGW gcc-canadian-sdk

[David Huggins-Daines]

When building a Canadian cross SDK for a MinGW host, installation of
gcc-canadian-sdk fails, because it is configured using a Windows path
as its ${prefix}.  Therefore it's not sufficient to use DESTDIR to
install it; this leads to it being installed in ${DESTDIR}C: which
is not where the rest of the recipe expects it.

This patch forces it to use the Unix ${prefix} variable, which has
no drive letter, for installation.  I'm not 100% certain this is the
right solution but it doesn't seem to break normal SDK builds.

---
 recipes/gcc/gcc-package-sdk.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/gcc/gcc-package-sdk.inc b/recipes/gcc/gcc-package-sdk.inc
index 0dc19c7..17d44a1 100644
--- a/recipes/gcc/gcc-package-sdk.inc
+++ b/recipes/gcc/gcc-package-sdk.inc
@@ -29,7 +29,7 @@ FILES_${PN}-doc = "\
     "
 
 do_install () {
-	oe_runmake 'DESTDIR=${D}' install
+	oe_runmake 'DESTDIR=${D}' 'prefix=${prefix}' install
 
 	# Cleanup some of the ${libdir}{,exec}/gcc stuff ...
 	rm -r ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/install-tools
-- 
1.5.6.3

Re: [PATCH] fix do_install for MinGW gcc-canadian-sdk

[Tom Rini]

On Thu, Apr 16, 2009 at 04:03:03PM -0400, David Huggins-Daines wrote:

> When building a Canadian cross SDK for a MinGW host, installation of
> gcc-canadian-sdk fails, because it is configured using a Windows path
> as its ${prefix}.  Therefore it's not sufficient to use DESTDIR to
> install it; this leads to it being installed in ${DESTDIR}C: which
> is not where the rest of the recipe expects it.
> 
> This patch forces it to use the Unix ${prefix} variable, which has
> no drive letter, for installation.  I'm not 100% certain this is the
> right solution but it doesn't seem to break normal SDK builds.

Is this using the distro / machine you mentioned before?  This should
all be fine and we just end up making a 'C:' dir.  I'm very curious here
as at some point prior to pushing canadian stuff originally I had the
same patch, but on trying to confirm I needed it, I suddenly didn't need
it anymore.

-- 
Tom Rini

Re: [PATCH] update canadian-sdk to match meta-toolchain

[Tom Rini]

On Thu, Apr 16, 2009 at 04:03:02PM -0400, David Huggins-Daines wrote:

> This patch synchronizes (to some extent) canadian-sdk.bb with
> meta-toolchain.bb.  Unlike meta-toolchain, it does not build an
> -extras package.  There's a lot of code duplication there which I will
> leave to the experts to sort out :)

I _think_ this is OK.  I'm iffy at best on if opkg will actually work in
Windows, but otherwise, yeah.  I'm going to go kick a build or two prior
to both of these patches then put 'em in and see what happens.

-- 
Tom Rini

Re: [PATCH] fix do_install for MinGW gcc-canadian-sdk

[David Huggins-Daines]

Tom Rini wrote:
>
> Is this using the distro / machine you mentioned before?  This should
> all be fine and we just end up making a 'C:' dir.  I'm very curious here
> as at some point prior to pushing canadian stuff originally I had the
> same patch, but on trying to confirm I needed it, I suddenly didn't need
> it anymore.
>
>   
Yeah - I can send you the distro, machine, and local.conf if you like, 
or publish my git repository. I am using these extra definitions in 
local.conf for building the MinGW SDK:

SDK_ARCH = "i686"
SDK_OS = "mingw32"
SDK_EXEEXT = ".exe"
OVERRIDES .= ":sdk-mingw32"

Re: [PATCH] update canadian-sdk to match meta-toolchain

[David Huggins-Daines]

Tom Rini wrote:
>
> I _think_ this is OK.  I'm iffy at best on if opkg will actually work in
> Windows, but otherwise, yeah.  I'm going to go kick a build or two prior
> to both of these patches then put 'em in and see what happens.
>   
Yeah, actually I have my doubts about it too. I haven't tried.

Of course this doesn't preclude a Canadian SDK for some other host 
machine where it would work...

Re: [PATCH] fix do_install for MinGW gcc-canadian-sdk

[Tom Rini]

On Thu, Apr 16, 2009 at 04:59:44PM -0400, David Huggins-Daines wrote:
> Tom Rini wrote:
>>
>> Is this using the distro / machine you mentioned before?  This should
>> all be fine and we just end up making a 'C:' dir.  I'm very curious here
>> as at some point prior to pushing canadian stuff originally I had the
>> same patch, but on trying to confirm I needed it, I suddenly didn't need
>> it anymore.
>>
>>   
> Yeah - I can send you the distro, machine, and local.conf if you like,  
> or publish my git repository. I am using these extra definitions in  
> local.conf for building the MinGW SDK:
>
> SDK_ARCH = "i686"
> SDK_OS = "mingw32"
> SDK_EXEEXT = ".exe"
> OVERRIDES .= ":sdk-mingw32"

Looks fine except for the OVERRIDES.  I don't use any special ones, so
you shouldn't need any either :)  (But yes, there are bits of code that
reference sdk-mingw32 and need fixing).

-- 
Tom Rini

Re: [PATCH] update canadian-sdk to match meta-toolchain

[Tom Rini]

On Thu, Apr 16, 2009 at 05:01:10PM -0400, David Huggins-Daines wrote:
> Tom Rini wrote:
>>
>> I _think_ this is OK.  I'm iffy at best on if opkg will actually work in
>> Windows, but otherwise, yeah.  I'm going to go kick a build or two prior
>> to both of these patches then put 'em in and see what happens.
>>   
> Yeah, actually I have my doubts about it too. I haven't tried.
>
> Of course this doesn't preclude a Canadian SDK for some other host  
> machine where it would work...

True.  Still looking for someone to give that a shot :)

-- 
Tom Rini

Re: [PATCH] fix do_install for MinGW gcc-canadian-sdk

[Tom Rini]

On Thu, Apr 16, 2009 at 02:31:44PM -0700, Tom Rini wrote:
> On Thu, Apr 16, 2009 at 04:59:44PM -0400, David Huggins-Daines wrote:
> > Tom Rini wrote:
> >>
> >> Is this using the distro / machine you mentioned before?  This should
> >> all be fine and we just end up making a 'C:' dir.  I'm very curious here
> >> as at some point prior to pushing canadian stuff originally I had the
> >> same patch, but on trying to confirm I needed it, I suddenly didn't need
> >> it anymore.
> >>
> >>   
> > Yeah - I can send you the distro, machine, and local.conf if you like,  
> > or publish my git repository. I am using these extra definitions in  
> > local.conf for building the MinGW SDK:
> >
> > SDK_ARCH = "i686"
> > SDK_OS = "mingw32"
> > SDK_EXEEXT = ".exe"
> > OVERRIDES .= ":sdk-mingw32"
> 
> Looks fine except for the OVERRIDES.  I don't use any special ones, so
> you shouldn't need any either :)  (But yes, there are bits of code that
> reference sdk-mingw32 and need fixing).

In fact, the OVERRIDES is causing the problem.  In stable there's still
some sdk-mingw32 overrides which aren't right, but I didn't notice they
needed fixing (removing usually) as I wasn't adding any additional
overrides since back when RP asked me to drop that (which explains why I
needed your patch at some point, then no longer did).  There's a few of
these left in .dev still, which I'm removing and doing a test build of
now.  Once this is done, I think Canadian stuff will be in good enough
shape that I'll get a series together for stable/2009.

-- 
Tom Rini

Re: [PATCH] update canadian-sdk to match meta-toolchain

[Tom Rini]

On Thu, Apr 16, 2009 at 04:03:02PM -0400, David Huggins-Daines wrote:

> This patch synchronizes (to some extent) canadian-sdk.bb with
> meta-toolchain.bb.  Unlike meta-toolchain, it does not build an
> -extras package.  There's a lot of code duplication there which I will
> leave to the experts to sort out :)

Pushed to dev.  Starting on an SDK set of patches then Canadian SDK
patches for stable now.

-- 
Tom Rini