* [PATCH] ALSA: off by 1 in snd_emu10k1_wait()
@ 2009-04-16 21:54 Roel Kluin
2009-04-17 10:54 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-04-16 21:54 UTC (permalink / raw)
To: perex, alsa-devel
Is this useful? It was in Linus' git tree.
----------------------------->8-----------------8<------------------------------
With `while (count++ < 16384)' count reaches 16385.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/sound/pci/emu10k1/io.c b/sound/pci/emu10k1/io.c
index 4bfc31d..c1a5aa1 100644
--- a/sound/pci/emu10k1/io.c
+++ b/sound/pci/emu10k1/io.c
@@ -490,7 +490,7 @@ void snd_emu10k1_wait(struct snd_emu10k1 *emu, unsigned int wait)
if (newtime != curtime)
break;
}
- if (count >= 16384)
+ if (count > 16384)
break;
curtime = newtime;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: off by 1 in snd_emu10k1_wait()
2009-04-16 21:54 [PATCH] ALSA: off by 1 in snd_emu10k1_wait() Roel Kluin
@ 2009-04-17 10:54 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-04-17 10:54 UTC (permalink / raw)
To: Roel Kluin; +Cc: alsa-devel
At Thu, 16 Apr 2009 23:54:04 +0200,
Roel Kluin wrote:
>
> Is this useful? It was in Linus' git tree.
Well, I guess it won't change any real behavior, but a bug is a bug :)
Applied now.
Thanks,
Takashi
> ----------------------------->8-----------------8<------------------------------
> With `while (count++ < 16384)' count reaches 16385.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/sound/pci/emu10k1/io.c b/sound/pci/emu10k1/io.c
> index 4bfc31d..c1a5aa1 100644
> --- a/sound/pci/emu10k1/io.c
> +++ b/sound/pci/emu10k1/io.c
> @@ -490,7 +490,7 @@ void snd_emu10k1_wait(struct snd_emu10k1 *emu, unsigned int wait)
> if (newtime != curtime)
> break;
> }
> - if (count >= 16384)
> + if (count > 16384)
> break;
> curtime = newtime;
> }
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-17 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-16 21:54 [PATCH] ALSA: off by 1 in snd_emu10k1_wait() Roel Kluin
2009-04-17 10:54 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.