All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ioemu: fix sdl mode
@ 2009-04-17 12:31 Cui, Dexuan
  2009-04-17 13:10 ` Stefano Stabellini
  0 siblings, 1 reply; 2+ messages in thread
From: Cui, Dexuan @ 2009-04-17 12:31 UTC (permalink / raw)
  To: Ian Jackson, Stefano Stabellini; +Cc: Xen-devel

When I use "sdl=1 vnc=0" in hvm guest config file, qemu-dm would exit due to a de-reference to a NULL pointer. The regression is introduced by 3793d85f111a0dfe055ca8ac17a9d1881af43240.
The attached patch fixes the issue.

Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>

diff --git a/sdl.c b/sdl.c
index 39ff4e3..e0cd07b 100644
--- a/sdl.c
+++ b/sdl.c
@@ -198,7 +198,7 @@ static void do_sdl_resize(int new_width, int new_height, int bpp)
             opengl_enabled = 0;
             dcl->dpy_update = sdl_update;
             dcl->dpy_setdata = sdl_setdata;
-            do_sdl_resize(real_screen->w, real_screen->h, real_screen->format->BitsPerPixel);
+            do_sdl_resize(width, height, bpp);
             return;
         }
         fprintf(stderr, "Could not open SDL display\n");

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ioemu: fix sdl mode
  2009-04-17 12:31 [PATCH] ioemu: fix sdl mode Cui, Dexuan
@ 2009-04-17 13:10 ` Stefano Stabellini
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2009-04-17 13:10 UTC (permalink / raw)
  To: Cui, Dexuan; +Cc: Xen-devel, Ian Jackson

Cui, Dexuan wrote:

> When I use "sdl=1 vnc=0" in hvm guest config file, qemu-dm would exit due to a de-reference to a NULL pointer. The regression is introduced by 3793d85f111a0dfe055ca8ac17a9d1881af43240.
> The attached patch fixes the issue.
> 
> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
> 

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-17 13:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-17 12:31 [PATCH] ioemu: fix sdl mode Cui, Dexuan
2009-04-17 13:10 ` Stefano Stabellini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.