From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Paul Mackerras <paulus@samba.org>
Cc: subrata@linux.vnet.ibm.com,
Linuxppc-dev <Linuxppc-dev@ozlabs.org>,
sachinp <sachinp@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Olof Johansson <olof@lixom.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: [patch] powerpc/pasemi: Fix no SMP build error
Date: Fri, 17 Apr 2009 09:36:37 -0700 [thread overview]
Message-ID: <49E8B015.7060808@am.sony.com> (raw)
In-Reply-To: <1239285094.5188.65.camel@subratamodak.linux.ibm.com>
A non-SMP version of smp_send_stop() is now included in smp.h.
Remove the unneeded def in the pasemi setup.c.
Fixes build errors like these when CONFIG_SMP=n:
arch/powerpc/platforms/pasemi/setup.c:48: error: redefinition of ‘smp_send_stop’
include/linux/smp.h:125: error: previous definition of 'smp_send_stop' was here
Reported-by: subrata@linux.vnet.ibm.com
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c
index c64fb5b..153051e 100644
--- a/arch/powerpc/platforms/pasemi/setup.c
+++ b/arch/powerpc/platforms/pasemi/setup.c
@@ -44,10 +44,6 @@
#include "pasemi.h"
-#if !defined(CONFIG_SMP)
-static void smp_send_stop(void) {}
-#endif
-
/* SDC reset register, must be pre-mapped at reset time */
static void __iomem *reset_reg;
WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Paul Mackerras <paulus@samba.org>
Cc: sachinp <sachinp@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linuxppc-dev <Linuxppc-dev@ozlabs.org>,
linux-next <linux-next@vger.kernel.org>,
Olof Johansson <olof@lixom.net>,
subrata@linux.vnet.ibm.com
Subject: [patch] powerpc/pasemi: Fix no SMP build error
Date: Fri, 17 Apr 2009 09:36:37 -0700 [thread overview]
Message-ID: <49E8B015.7060808@am.sony.com> (raw)
In-Reply-To: <1239285094.5188.65.camel@subratamodak.linux.ibm.com>
A non-SMP version of smp_send_stop() is now included in smp.h.
Remove the unneeded def in the pasemi setup.c.
Fixes build errors like these when CONFIG_SMP=3Dn:
arch/powerpc/platforms/pasemi/setup.c:48: error: redefinition of =E2=80=
=98smp_send_stop=E2=80=99
include/linux/smp.h:125: error: previous definition of 'smp_send_stop' =
was here
Reported-by: subrata@linux.vnet.ibm.com
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platfor=
ms/pasemi/setup.c
index c64fb5b..153051e 100644
--- a/arch/powerpc/platforms/pasemi/setup.c
+++ b/arch/powerpc/platforms/pasemi/setup.c
@@ -44,10 +44,6 @@
=20
#include "pasemi.h"
=20
-#if !defined(CONFIG_SMP)
-static void smp_send_stop(void) {}
-#endif
-
/* SDC reset register, must be pre-mapped at reset time */
static void __iomem *reset_reg;
=20
next prev parent reply other threads:[~2009-04-17 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 13:51 [BUILD FAILURE 03] Next April 9 : PPC64 randconfig [arch/powerpc/platforms/pasemi/setup.o] Subrata Modak
2009-04-09 13:51 ` Subrata Modak
2009-04-17 16:36 ` Geoff Levand [this message]
2009-04-17 16:36 ` [patch] powerpc/pasemi: Fix no SMP build error Geoff Levand
2009-04-21 17:25 ` Olof Johansson
2009-04-21 17:25 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E8B015.7060808@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.