Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches

[Kevin Wolf <kwolf@redhat.com>]

Blue Swirl schrieb:
> On 4/20/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> Blue Swirl wrote:
>>
>>> Hi,
>>>
>>> I gathered a few common complaints about patch submission, hopefully
>>> not too much affected by my consumption of small amounts of various
>>> alcoholic substances.
>>>
>>> Comments, objections?
>>>
>>>
>>
>>> +SP4.1: It must be possible to apply the patch with quilt (equivalent
>>> +to patch -p1) and "git am" without any editing or extra flags
>>>
>>  svn diff generates -p0 patches so both -p1 and -p0 should be accepted.
> 
> Quilt does not accept -p0 patches without extra work. Remember, the
> idea is to reduce our burden, make it easier to test and apply
> patches.

I think you'll survive the extra work of adding a -p0 to your series 
file from time to time. Currently SVN is the official solution of qemu 
and it's not obvious how you would create -p1 patches with svn diff. And 
nowadays most patches are generated with git anyway.

Kevin