Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches

[Anthony Liguori <anthony@codemonkey.ws>]

Blue Swirl wrote:
> On 4/20/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> Blue Swirl wrote:
>>
>>     
>>> Hi,
>>>
>>> I gathered a few common complaints about patch submission, hopefully
>>> not too much affected by my consumption of small amounts of various
>>> alcoholic substances.
>>>
>>> Comments, objections?
>>>
>>>
>>>       
>>     
>>> +SP4.1: It must be possible to apply the patch with quilt (equivalent
>>> +to patch -p1) and "git am" without any editing or extra flags
>>>
>>>       
>>  svn diff generates -p0 patches so both -p1 and -p0 should be accepted.
>>     
>
> Quilt does not accept -p0 patches without extra work. Remember, the
> idea is to reduce our burden, make it easier to test and apply
> patches.
>   

guilt does ;-)

FWIW, I'm working on getting the email commit script in place for the 
Savannah git repo.  That's the last bit needed to switch from svn -> git.

After that, a git-send-email requirement (or equiv) would make a lot of 
sense as it significantly reduces the maintainers work via git-am.

Regards,

Anthony Liguori

> Diff can generate other types of diffs besides the unified type but we
> don't want any other.
>
>
>