From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] fs_enet: Remove dead code
Date: Wed, 22 Apr 2009 16:30:58 -0500 [thread overview]
Message-ID: <49EF8C92.8050403@freescale.com> (raw)
In-Reply-To: <1240435170-5183-1-git-send-email-galak@kernel.crashing.org>
Kumar Gala wrote:
> @@ -318,32 +314,6 @@ static void restart(struct net_device *dev)
> /*
> * adjust to speed (only for DUET & RMII)
> */
> -#ifdef CONFIG_DUET
> - if (fpi->use_rmii) {
Please remove the comment that goes with the code being removed.
Otherwise, ACK.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] fs_enet: Remove dead code
Date: Wed, 22 Apr 2009 16:30:58 -0500 [thread overview]
Message-ID: <49EF8C92.8050403@freescale.com> (raw)
In-Reply-To: <1240435170-5183-1-git-send-email-galak@kernel.crashing.org>
Kumar Gala wrote:
> @@ -318,32 +314,6 @@ static void restart(struct net_device *dev)
> /*
> * adjust to speed (only for DUET & RMII)
> */
> -#ifdef CONFIG_DUET
> - if (fpi->use_rmii) {
Please remove the comment that goes with the code being removed.
Otherwise, ACK.
-Scott
next prev parent reply other threads:[~2009-04-22 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 21:19 [PATCH] fs_enet: Remove dead code Kumar Gala
2009-04-22 21:30 ` Scott Wood [this message]
2009-04-22 21:30 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EF8C92.8050403@freescale.com \
--to=scottwood@freescale.com \
--cc=davem@davemloft.net \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.