All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Simon Bienlein <s.bienlein@gmx.de>,
	Qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] Re: Question about KVM and PC speaker
Date: Thu, 23 Apr 2009 19:42:14 +0200	[thread overview]
Message-ID: <49F0A876.4050902@siemens.com> (raw)
In-Reply-To: <49F04C80.2040204@redhat.com>

Avi Kivity wrote:
> Jan Kiszka wrote:
>> Avi Kivity wrote:
>>  
>>> Jan Kiszka wrote:
>>>    
>>>> Huh, it is! Then the problem is a KVM-only thing: The kernel part hooks
>>>> onto those resources but doesn't communicate changes to this user space
>>>> backend.
>>>>         
>>> In this case, the -no-kvm-pit option should help.
>>>     
>>
>> Probably fine in many cases (where the PIT is no longer used anyway),
>> just a bit unintuitive for users.
>>   
> 
> Yes, it's only a workaround.
> 
>> I wonder why KVM moved port 0x61 handling into kernel space at all. By
>> leaving it in pcspk hands and extending the latter to sync with the
>> in-kernel PIT on sample generation, this speaker regression (of
>> kvm-userspace) should have been avoidable.
>>   
> 
> I'd rather not have partial components in the kernel.  This case is
> particularly icky though.

But you surely don't want to issue the sound from kernel space.
Moreover, these are separate components: the PIT doesn't bother about
the speaker, if it's on or off. We just need to make pcspk KVM-aware. I
think I will post a patch later today.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>,
	Simon Bienlein <s.bienlein@gmx.de>
Subject: Re: [Qemu-devel] Re: Question about KVM and PC speaker
Date: Thu, 23 Apr 2009 19:42:14 +0200	[thread overview]
Message-ID: <49F0A876.4050902@siemens.com> (raw)
In-Reply-To: <49F04C80.2040204@redhat.com>

Avi Kivity wrote:
> Jan Kiszka wrote:
>> Avi Kivity wrote:
>>  
>>> Jan Kiszka wrote:
>>>    
>>>> Huh, it is! Then the problem is a KVM-only thing: The kernel part hooks
>>>> onto those resources but doesn't communicate changes to this user space
>>>> backend.
>>>>         
>>> In this case, the -no-kvm-pit option should help.
>>>     
>>
>> Probably fine in many cases (where the PIT is no longer used anyway),
>> just a bit unintuitive for users.
>>   
> 
> Yes, it's only a workaround.
> 
>> I wonder why KVM moved port 0x61 handling into kernel space at all. By
>> leaving it in pcspk hands and extending the latter to sync with the
>> in-kernel PIT on sample generation, this speaker regression (of
>> kvm-userspace) should have been avoidable.
>>   
> 
> I'd rather not have partial components in the kernel.  This case is
> particularly icky though.

But you surely don't want to issue the sound from kernel space.
Moreover, these are separate components: the PIT doesn't bother about
the speaker, if it's on or off. We just need to make pcspk KVM-aware. I
think I will post a patch later today.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

  reply	other threads:[~2009-04-23 17:43 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 19:02 [Qemu-devel] Question about KVM and PC speaker Simon Bienlein
2009-04-23  7:45 ` [Qemu-devel] " Jan Kiszka
2009-04-23  8:32   ` Samuel Thibault
2009-04-23  9:06     ` Kevin Wolf
2009-04-23  9:23       ` Samuel Thibault
2009-04-23  9:15     ` Jan Kiszka
2009-04-23  9:25       ` Samuel Thibault
2009-04-23  9:33         ` Jan Kiszka
2009-04-23  9:50           ` Avi Kivity
2009-04-23 10:29             ` Jan Kiszka
2009-04-23 10:29               ` Jan Kiszka
2009-04-23 11:09               ` Avi Kivity
2009-04-23 11:09                 ` Avi Kivity
2009-04-23 17:42                 ` Jan Kiszka [this message]
2009-04-23 17:42                   ` Jan Kiszka
2009-05-04 16:34               ` Simon Bienlein
2009-05-04 16:34                 ` Simon Bienlein
2009-05-04 20:29                 ` Jan Kiszka
2009-05-04 20:56                   ` Samuel Thibault
2009-05-04 20:56                     ` [Qemu-devel] " Samuel Thibault
2009-05-04 21:00                     ` Jan Kiszka
2009-05-05 15:59                       ` Simon Bienlein
2009-05-05 22:34                         ` Sebastian Herbszt
2009-05-05 22:34                           ` Sebastian Herbszt
2009-05-06 10:34                           ` Jan Kiszka
2009-05-06 10:34                             ` Jan Kiszka
2009-05-06 20:55                             ` Sebastian Herbszt
2009-05-06 20:55                               ` Sebastian Herbszt
2009-05-07  8:12                               ` Jan Kiszka
2009-05-07  8:12                                 ` Jan Kiszka
2009-05-09 22:21                                 ` Sebastian Herbszt
2009-05-09 22:21                                   ` Sebastian Herbszt
2009-05-12  7:32                                   ` Jan Kiszka
2009-05-12  7:32                                     ` Jan Kiszka
2009-05-12 21:06                                     ` Sebastian Herbszt
2009-05-12 21:06                                       ` Sebastian Herbszt
2009-05-12 21:50                                       ` Jan Kiszka
2009-05-12 21:50                                         ` Jan Kiszka
2009-05-12 22:21                                         ` Sebastian Herbszt
2009-05-12 22:21                                           ` Sebastian Herbszt
2009-05-12 22:27                                           ` Samuel Thibault
2009-05-12 22:37                                           ` malc
2009-05-12 22:37                                             ` [Qemu-devel] " malc
2009-05-14 19:48                                             ` Sebastian Herbszt
2009-05-14 19:48                                               ` Sebastian Herbszt
2009-05-14 22:01                                               ` malc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F0A876.4050902@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Qemu-devel@nongnu.org \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=s.bienlein@gmx.de \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.