Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu

[Greg Ungerer <gerg@snapgear.com>]

Oleg Nesterov wrote:
> m68k sets PT_DTRACE in trap_c() but never uses it.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Acked-by: Greg Ungerer <gerg@uclinux.org>


>  arch/m68k/kernel/traps.c            |    1 -
>  arch/m68knommu/kernel/asm-offsets.c |    1 -
>  arch/m68knommu/kernel/traps.c       |    1 -
>  3 files changed, 3 deletions(-)
> 
> --- PTRACE/arch/m68k/kernel/traps.c~DT_3_SET	2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68k/kernel/traps.c	2009-04-22 21:52:23.000000000 +0200
> @@ -1057,7 +1057,6 @@ asmlinkage void trap_c(struct frame *fp)
>  	if (fp->ptregs.sr & PS_S) {
>  		if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
>  			/* traced a trapping instruction */
> -			current->ptrace |= PT_DTRACE;
>  		} else
>  			bad_super_trap(fp);
>  		return;
> --- PTRACE/arch/m68knommu/kernel/asm-offsets.c~DT_3_SET	2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68knommu/kernel/asm-offsets.c	2009-04-22 21:53:46.000000000 +0200
> @@ -79,7 +79,6 @@ int main(void)
>  	DEFINE(TRAP_TRACE, TRAP_TRACE);
>  
>  	DEFINE(PT_PTRACED, PT_PTRACED);
> -	DEFINE(PT_DTRACE, PT_DTRACE);
>  
>  	DEFINE(THREAD_SIZE, THREAD_SIZE);
>  
> --- PTRACE/arch/m68knommu/kernel/traps.c~DT_3_SET	2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68knommu/kernel/traps.c	2009-04-22 21:54:29.000000000 +0200
> @@ -200,7 +200,6 @@ asmlinkage void trap_c(struct frame *fp)
>  	if (fp->ptregs.sr & PS_S) {
>  		if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
>  			/* traced a trapping instruction */
> -			current->ptrace |= PT_DTRACE;
>  		} else
>  			bad_super_trap(fp);
>  		return;
> 
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com