From: Andreas Schwab <schwab@linux-m68k.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Roland McGrath <roland@redhat.com>,
Chris Zankel <chris@zankel.net>,
David Howells <dhowells@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Ungerer <gerg@uclinux.org>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Helge Deller <deller@gmx.de>,
Hirokazu Takata <takata@linux-m32r.org>,
Jeff Dike <jdike@addtoit.com>, Kyle McMartin <kyle@mcmartin.ca>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Mike Frysinger <vapier.adi@gmail.com>,
Paul Mundt <lethal@linux-sh.org>,
Roman Zippel <zippel@linux-m68k.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu
Date: Fri, 24 Apr 2009 12:06:32 +0200 [thread overview]
Message-ID: <m2tz4e5psn.fsf@igel.home> (raw)
In-Reply-To: <20090423193211.GA14892@redhat.com> (Oleg Nesterov's message of "Thu, 23 Apr 2009 21:32:11 +0200")
Oleg Nesterov <oleg@redhat.com> writes:
> m68k sets PT_DTRACE in trap_c() but never uses it.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> arch/m68k/kernel/traps.c | 1 -
> arch/m68knommu/kernel/asm-offsets.c | 1 -
> arch/m68knommu/kernel/traps.c | 1 -
> 3 files changed, 3 deletions(-)
>
> --- PTRACE/arch/m68k/kernel/traps.c~DT_3_SET 2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68k/kernel/traps.c 2009-04-22 21:52:23.000000000 +0200
> @@ -1057,7 +1057,6 @@ asmlinkage void trap_c(struct frame *fp)
> if (fp->ptregs.sr & PS_S) {
> if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
> /* traced a trapping instruction */
> - current->ptrace |= PT_DTRACE;
This is supposed to be setting the TIF_DELAYED_TRACE thread flag.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-04-24 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 19:32 [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu Oleg Nesterov
2009-04-24 1:17 ` Greg Ungerer
2009-04-24 7:03 ` Geert Uytterhoeven
2009-04-24 10:06 ` Andreas Schwab [this message]
2009-04-24 10:57 ` Geert Uytterhoeven
2009-04-24 12:04 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tz4e5psn.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=hskinnemoen@atmel.com \
--cc=jdike@addtoit.com \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=takata@linux-m32r.org \
--cc=vapier.adi@gmail.com \
--cc=ysato@users.sourceforge.jp \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.