* [PATCH] Fix segfault when using -U, -G and -M options in dmsetup
@ 2009-04-24 10:42 Peter Rajnoha
2009-04-24 11:12 ` Alasdair G Kergon
0 siblings, 1 reply; 2+ messages in thread
From: Peter Rajnoha @ 2009-04-24 10:42 UTC (permalink / raw)
To: lvm-devel
It seems nobody uses these options :) Permissions will be covered
by udev anyway...
We have to define ":" in getopt for options that require parameters.
Peter
diff --git a/tools/dmsetup.c b/tools/dmsetup.c
index 0d6a371..1194c5f 100644
--- a/tools/dmsetup.c
+++ b/tools/dmsetup.c
@@ -2565,7 +2565,7 @@ static int _process_switches(int *argc, char ***argv, const char *dev_dir)
optarg = 0;
optind = OPTIND_INIT;
- while ((ind = -1, c = GETOPTLONG_FN(*argc, *argv, "cCfGj:m:Mno:O:ru:Uv",
+ while ((ind = -1, c = GETOPTLONG_FN(*argc, *argv, "cCfG:j:m:M:no:O:ru:U:v",
long_options, NULL)) != -1) {
if (c == ':' || c == '?')
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Fix segfault when using -U, -G and -M options in dmsetup
2009-04-24 10:42 [PATCH] Fix segfault when using -U, -G and -M options in dmsetup Peter Rajnoha
@ 2009-04-24 11:12 ` Alasdair G Kergon
0 siblings, 0 replies; 2+ messages in thread
From: Alasdair G Kergon @ 2009-04-24 11:12 UTC (permalink / raw)
To: lvm-devel
On Fri, Apr 24, 2009 at 12:42:38PM +0200, Peter Rajnoha wrote:
> We have to define ":" in getopt for options that require parameters.
Ack.
Alasdair
--
agk at redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-24 11:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-24 10:42 [PATCH] Fix segfault when using -U, -G and -M options in dmsetup Peter Rajnoha
2009-04-24 11:12 ` Alasdair G Kergon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.