[RFC][PATCH] Make initscripts banner stop trying to be smart

[RFC][PATCH] Make initscripts banner stop trying to be smart

[Tom Rini]

I ran into this on my boards that start out with the really minimal
(console and null only) set of dev nodes prior to udev running.  The
banner script looks around for what might be the vtmaster (aka what's
got console) to say that we're booting.  But that's where things go by
default anyhow.  This would also let slugos use the normal version, if
they want.

Signed-off-by: Tom Rini <trini@embeddedalley.com>

diff --git a/recipes/initscripts/initscripts-1.0/banner b/recipes/initscripts/initscripts-1.0/banner
index 0349ce1..4e69c29 100644
--- a/recipes/initscripts/initscripts-1.0/banner
+++ b/recipes/initscripts/initscripts-1.0/banner
@@ -1,17 +1,3 @@
 #!/bin/sh
 
-if [ ! -e /dev/tty ]; then
-    /bin/mknod -m 0666 /dev/tty c 5 0
-fi
-
-if ( > /dev/tty0 ) 2>/dev/null; then
-    vtmaster=/dev/tty0
-elif ( > /dev/vc/0 ) 2>/dev/null; then
-    vtmaster=/dev/vc/0
-elif ( > /dev/console ) 2>/dev/null; then
-    vtmaster=/dev/console
-else
-    vtmaster=/dev/null
-fi
-echo > $vtmaster
-echo "Please wait: booting..." > $vtmaster
+echo "Please wait: booting..."
diff --git a/recipes/initscripts/initscripts_1.0.bb b/recipes/initscripts/initscripts_1.0.bb
index cbcfec5..6642144 100644
--- a/recipes/initscripts/initscripts_1.0.bb
+++ b/recipes/initscripts/initscripts_1.0.bb
@@ -4,7 +4,7 @@ PRIORITY = "required"
 DEPENDS = "makedevs"
 RDEPENDS = "makedevs"
 LICENSE = "GPL"
-PR = "r114"
+PR = "r115"
 
 SRC_URI = "file://functions \
            file://halt \

-- 
Tom Rini

Re: [RFC][PATCH] Make initscripts banner stop trying to be smart

[Koen Kooi]

On 23-04-09 17:37, Tom Rini wrote:
> I ran into this on my boards that start out with the really minimal
> (console and null only) set of dev nodes prior to udev running.  The
> banner script looks around for what might be the vtmaster (aka what's
> got console) to say that we're booting.  But that's where things go by
> default anyhow.  This would also let slugos use the normal version, if
> they want.

I looked into the history of this file and it seems it stems from the 
creation of the OE project (when we still had .oe files) and the only 
edit to is is to add the check for /dev/console.

Anyway:

Acked-by: Koen Kooi <koen@openembedded.org>



> Signed-off-by: Tom Rini<trini@embeddedalley.com>
>
> diff --git a/recipes/initscripts/initscripts-1.0/banner b/recipes/initscripts/initscripts-1.0/banner
> index 0349ce1..4e69c29 100644
> --- a/recipes/initscripts/initscripts-1.0/banner
> +++ b/recipes/initscripts/initscripts-1.0/banner
> @@ -1,17 +1,3 @@
>   #!/bin/sh
>
> -if [ ! -e /dev/tty ]; then
> -    /bin/mknod -m 0666 /dev/tty c 5 0
> -fi
> -
> -if (>  /dev/tty0 ) 2>/dev/null; then
> -    vtmaster=/dev/tty0
> -elif (>  /dev/vc/0 ) 2>/dev/null; then
> -    vtmaster=/dev/vc/0
> -elif (>  /dev/console ) 2>/dev/null; then
> -    vtmaster=/dev/console
> -else
> -    vtmaster=/dev/null
> -fi
> -echo>  $vtmaster
> -echo "Please wait: booting...">  $vtmaster
> +echo "Please wait: booting..."
> diff --git a/recipes/initscripts/initscripts_1.0.bb b/recipes/initscripts/initscripts_1.0.bb
> index cbcfec5..6642144 100644
> --- a/recipes/initscripts/initscripts_1.0.bb
> +++ b/recipes/initscripts/initscripts_1.0.bb
> @@ -4,7 +4,7 @@ PRIORITY = "required"
>   DEPENDS = "makedevs"
>   RDEPENDS = "makedevs"
>   LICENSE = "GPL"
> -PR = "r114"
> +PR = "r115"
>
>   SRC_URI = "file://functions \
>              file://halt \
>

Re: [RFC][PATCH] Make initscripts banner stop trying to be smart

[Mike (mwester)]

Tom Rini wrote:
> I ran into this on my boards that start out with the really minimal
> (console and null only) set of dev nodes prior to udev running.  The
> banner script looks around for what might be the vtmaster (aka what's
> got console) to say that we're booting.  But that's where things go by
> default anyhow.  This would also let slugos use the normal version, if
> they want.
> 
> Signed-off-by: Tom Rini <trini@embeddedalley.com>

Acked-by: Mike Westerhof <mwester@dls.net>

Yes, SlugOS will happily return to using the normal version. :)


> diff --git a/recipes/initscripts/initscripts-1.0/banner b/recipes/initscripts/initscripts-1.0/banner
> index 0349ce1..4e69c29 100644
> --- a/recipes/initscripts/initscripts-1.0/banner
> +++ b/recipes/initscripts/initscripts-1.0/banner
> @@ -1,17 +1,3 @@
>  #!/bin/sh
>  
> -if [ ! -e /dev/tty ]; then
> -    /bin/mknod -m 0666 /dev/tty c 5 0
> -fi
> -
> -if ( > /dev/tty0 ) 2>/dev/null; then
> -    vtmaster=/dev/tty0
> -elif ( > /dev/vc/0 ) 2>/dev/null; then
> -    vtmaster=/dev/vc/0
> -elif ( > /dev/console ) 2>/dev/null; then
> -    vtmaster=/dev/console
> -else
> -    vtmaster=/dev/null
> -fi
> -echo > $vtmaster
> -echo "Please wait: booting..." > $vtmaster
> +echo "Please wait: booting..."
> diff --git a/recipes/initscripts/initscripts_1.0.bb b/recipes/initscripts/initscripts_1.0.bb
> index cbcfec5..6642144 100644
> --- a/recipes/initscripts/initscripts_1.0.bb
> +++ b/recipes/initscripts/initscripts_1.0.bb
> @@ -4,7 +4,7 @@ PRIORITY = "required"
>  DEPENDS = "makedevs"
>  RDEPENDS = "makedevs"
>  LICENSE = "GPL"
> -PR = "r114"
> +PR = "r115"
>  
>  SRC_URI = "file://functions \
>             file://halt \
>