All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ROMFS: romfs_dev_read() error ignored
@ 2009-04-26 12:51 Roel Kluin
  0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-04-26 12:51 UTC (permalink / raw)
  To: Al Viro; +Cc: linux-fsdevel

romfs_dev_read() may return -EIO, but ret is unsigned, so the errorpath
isn't taken.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/fs/romfs/super.c b/fs/romfs/super.c
index c53b5ef..4ab3c03 100644
--- a/fs/romfs/super.c
+++ b/fs/romfs/super.c
@@ -298,7 +298,8 @@ static struct inode *romfs_iget(struct super_block *sb, unsigned long pos)
 	struct romfs_inode ri;
 	struct inode *i;
 	unsigned long nlen;
-	unsigned nextfh, ret;
+	unsigned nextfh;
+	int ret;
 	umode_t mode;
 
 	/* we might have to traverse a chain of "hard link" file entries to get

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-26 12:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-26 12:51 [PATCH] ROMFS: romfs_dev_read() error ignored Roel Kluin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.