Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

[Jan Kiszka <jan.kiszka@siemens.com>]

Liu Yu-B13201 wrote:
>> -----Original Message-----
>> From: Jan Kiszka [mailto:jan.kiszka@siemens.com] 
>> Sent: Wednesday, April 29, 2009 6:38 PM
>> To: Liu Yu-B13201
>> Cc: qemu-devel@nongnu.org; kvm-ppc@vger.kernel.org
>> Subject: Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks 
>> to slot management
>>
>> Liu Yu-B13201 wrote:
>>>> -----Original Message-----
>>>> From: qemu-devel-bounces+yu.liu=freescale.com@nongnu.org 
>>>> [mailto:qemu-devel-bounces+yu.liu=freescale.com@nongnu.org] 
>>>> On Behalf Of Jan Kiszka
>>>> Sent: Sunday, April 12, 2009 1:20 AM
>>>> To: qemu-devel@nongnu.org
>>>> Subject: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to 
>>>> slot management
>>>>
>>>> Fail loudly if we run out of memory slot.
>>>>
>>>> Make sure that dirty log start/stop works with consistent 
>>>> memory regions
>>>> by reporting invalid parameters. This reveals several 
>>>> inconsistencies in
>>>> the vga code, patch to fix them follows later in this series.
>>>>
>>>> And, for simplicity reasons, also catch and report unaligned memory
>>>> regions passed to kvm_set_phys_mem (KVM works on page basis).
>>>>
>>> Commit d3f8d37fe2d0c24ec8bac9c94d5b0e2dc09c0d2a hurts kvm/powerpc
>>> The alignment check in kvm_set_phys_mem prevents pci 
>> controller and mpic initializing mmio regions.
>>
>> What is the alignment of those regions then? None? 
>> And do regions of
>> different types overlap even on the same page?
> I think so.
> 
>> Maybe the check reveals
>> some deeper conflict /wrt KVM. Can you point me to the 
>> involved code files?
>>
> 
> hw/ppc4xx_pci.c	ppc4xx_pci_init()
> hw/ppce500_pci.c	ppce500_pci_init()
> hw/openpic.c		mpic_init()
> hw/ppce500_mpc8544ds.c    serial_mm_init()
> 

Hmm, too bad that I have no platform at hand to test this. Could you
instrument kvm_set_phys_mem (on an older, working version), dumping its
arguments and post this trace?

TIA,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux