All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: richard@rsk.demon.co.uk, gregkh@suse.de,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: p80211wext.c: problem with IW_ENCODE_ALG_WEP
Date: Tue, 05 May 2009 13:35:04 +0000	[thread overview]
Message-ID: <4A004088.7000907@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0905051522010.9552@pc-004.diku.dk>

On 05/05/2009 03:22 PM, Julia Lawall wrote:
> -		if (!(ext->alg & IW_ENCODE_ALG_WEP)) {
> +		if (ext->alg != IW_ENCODE_ALG_WEP) {
>  			pr_debug("asked to set a non wep key :(");

While you're at it, there is a missing \n. Care to post a fix for that too?

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: richard@rsk.demon.co.uk, gregkh@suse.de,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: p80211wext.c: problem with IW_ENCODE_ALG_WEP
Date: Tue, 05 May 2009 15:35:04 +0200	[thread overview]
Message-ID: <4A004088.7000907@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0905051522010.9552@pc-004.diku.dk>

On 05/05/2009 03:22 PM, Julia Lawall wrote:
> -		if (!(ext->alg & IW_ENCODE_ALG_WEP)) {
> +		if (ext->alg != IW_ENCODE_ALG_WEP) {
>  			pr_debug("asked to set a non wep key :(");

While you're at it, there is a missing \n. Care to post a fix for that too?

  reply	other threads:[~2009-05-05 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05 13:22 p80211wext.c: problem with IW_ENCODE_ALG_WEP Julia Lawall
2009-05-05 13:22 ` Julia Lawall
2009-05-05 13:35 ` Jiri Slaby [this message]
2009-05-05 13:35   ` Jiri Slaby
2009-05-05 13:47   ` Julia Lawall
2009-05-05 13:47     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A004088.7000907@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=gregkh@suse.de \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@rsk.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.