FILESPATHPKG question

FILESPATHPKG question

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

I ran across the change in files path behavior today. I'm trying to test 
a beagleboard specific mux config in u-boot and was having trouble 
figuring out where the patch should go.

To get it to live in u-boot-git/beagleboard/foo.patch I made the 
following change to the u-boot_git.bb recipe:

diff --git a/recipes/u-boot/u-boot_git.bb b/recipes/u-boot/u-boot_git.bb
index 9846cd8..a133532 100644
--- a/recipes/u-boot/u-boot_git.bb
+++ b/recipes/u-boot/u-boot_git.bb
@@ -1,6 +1,8 @@
  require u-boot.inc
  PR ="r22"

+FILESPATHPKG = "u-boot-git:u-boot:files:."
+
  SRC_URI = "git://www.denx.de/git/u-boot.git;protocol=git "
  SRCREV_davinci-sffsdr = "4b50cd12a3b3c644153c4cf393f4a4c12289e5aa"
  SRCREV_davinci-dvevm = "4b50cd12a3b3c644153c4cf393f4a4c12289e5aa"
@@ -12,6 +14,7 @@ SRCREV_afeb9260 = 
"2077e348c2a84901022ad95311b47b70361e6daa"
  SRC_URI_beagleboard = 
"git://gitorious.org/u-boot-omap3/mainline.git;branch=omap3-dev;protocol=git 
\
                   file://fw-env.patch;patch=1 \
                   file://dss2.patch;patch=1 \
+                 file://mcspi3-mux.patch;patch=1 \
  "
  SRCREV_beagleboard = "2dea1db2a3b7c12ed70bbf8ee50755089c5e5170"
  PV_beagleboard = "2009.03+${PR}+gitr${SRCREV}"

Ignore the added patch :) Should I go ahead and push the FILESPATHPKG 
change? Otherwise all the patches will end up in the files directory ....

Philip

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]

Re: FILESPATHPKG question

[Phil Blundell]

On Wed, 2009-05-06 at 09:54 -0400, Philip Balister wrote:
> +FILESPATHPKG = "u-boot-git:u-boot:files:."

> Ignore the added patch :) Should I go ahead and push the FILESPATHPKG 
> change? Otherwise all the patches will end up in the files directory ....

Wouldn't you be better off just prepending to FILESPATHPKG rather than
replacing it?  As in, FILESPATHPKG =. "u-boot-git:" or something.

p.

Re: FILESPATHPKG question

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Phil Blundell wrote:
> On Wed, 2009-05-06 at 09:54 -0400, Philip Balister wrote:
>> +FILESPATHPKG = "u-boot-git:u-boot:files:."
> 
>> Ignore the added patch :) Should I go ahead and push the FILESPATHPKG 
>> change? Otherwise all the patches will end up in the files directory ....
> 
> Wouldn't you be better off just prepending to FILESPATHPKG rather than
> replacing it?  As in, FILESPATHPKG =. "u-boot-git:" or something.

I'd taken from a similar patch for uclibc. (That needs acks or comments).

What's the difference between =+ ad =.? Both work and I see more of the 
=+ form?

Philip


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]

Re: FILESPATHPKG question

[Phil Blundell]

On Wed, 2009-05-06 at 13:57 -0400, Philip Balister wrote:
> What's the difference between =+ ad =.? Both work and I see more of the 
> =+ form?

See the fine manual:

http://bitbake.berlios.de/manual/ch02.html#id868981

p.

Re: FILESPATHPKG question

[Chris Larson]

On Wed, May 6, 2009 at 10:57 AM, Philip Balister <philip@balister.org> wrote:
> Phil Blundell wrote:
>>
>> On Wed, 2009-05-06 at 09:54 -0400, Philip Balister wrote:
>>>
>>> +FILESPATHPKG = "u-boot-git:u-boot:files:."
>>
>>> Ignore the added patch :) Should I go ahead and push the FILESPATHPKG
>>> change? Otherwise all the patches will end up in the files directory ....
>>
>> Wouldn't you be better off just prepending to FILESPATHPKG rather than
>> replacing it?  As in, FILESPATHPKG =. "u-boot-git:" or something.
>
> I'd taken from a similar patch for uclibc. (That needs acks or comments).
>
> What's the difference between =+ ad =.? Both work and I see more of the =+
> form?

The + operations insert a space separator.  The FILESPATH vars use :
as their separator, not +, so no, they don't "Both work".
—
Chris Larson
clarson at kergoth dot com
clarson at mvista dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Software Engineer
MontaVista Software, Inc.

Re: FILESPATHPKG question

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

Chris Larson wrote:
> On Wed, May 6, 2009 at 10:57 AM, Philip Balister <philip@balister.org> wrote:
>> Phil Blundell wrote:
>>> On Wed, 2009-05-06 at 09:54 -0400, Philip Balister wrote:
>>>> +FILESPATHPKG = "u-boot-git:u-boot:files:."
>>>> Ignore the added patch :) Should I go ahead and push the FILESPATHPKG
>>>> change? Otherwise all the patches will end up in the files directory ....
>>> Wouldn't you be better off just prepending to FILESPATHPKG rather than
>>> replacing it?  As in, FILESPATHPKG =. "u-boot-git:" or something.
>> I'd taken from a similar patch for uclibc. (That needs acks or comments).
>>
>> What's the difference between =+ ad =.? Both work and I see more of the =+
>> form?
> 
> The + operations insert a space separator.  The FILESPATH vars use :
> as their separator, not +, so no, they don't "Both work".

Theoretically you might be correct :)

But,

FILESPATHPKG =+ "u-boot-git:"

is working for me. I'll push the =. form in case this changes in the 
future. I want to make sure I understand what is going on so we can get 
the most correct fixes in.

Could someone also look at the uclibc patch for this sort of thing?

http://patchwork.openembedded.org/patch/436/

Philip

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]