From: Scott Wood <scottwood@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: John Rigby <jrigby@gmail.com>,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
Wolfgang Denk <wd@denx.de>, Piotr Ziecik <kosmo@semihalf.com>
Subject: Re: [PATCH 02/12] fs_enet: Add MPC5121 FEC support.
Date: Wed, 06 May 2009 16:08:15 -0500 [thread overview]
Message-ID: <4A01FC3F.7080004@freescale.com> (raw)
In-Reply-To: <fa686aa40905061333q29c263c8p24856c048e30f4d0@mail.gmail.com>
Grant Likely wrote:
>> #ifdef CONFIG_FS_ENET_HAS_FEC
>> +#ifdef CONFIG_FS_ENET_MPC5121_FEC
>> + {
>> + .compatible = "fsl,mpc5121-fec",
>> + .data = (void *)&fs_fec_ops,
>> + },
>> +#else
>> {
>> .compatible = "fsl,pq1-fec-enet",
>> .data = (void *)&fs_fec_ops,
>> },
>> #endif
>> +#endif
>
> Hmmm. A lot of these #ifdefs in here. Does this have a multiplatform
> impact? Not to mention the fact that it's just plain ugly. :-)
Multiplatform between 512x and 8xx is currently impossible for other
reasons (512x and CPM2 is another matter). That said, less ifdefs would
be nice.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Wolfgang Denk <wd@denx.de>,
linuxppc-dev@ozlabs.org, Piotr Ziecik <kosmo@semihalf.com>,
John Rigby <jrigby@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 02/12] fs_enet: Add MPC5121 FEC support.
Date: Wed, 06 May 2009 16:08:15 -0500 [thread overview]
Message-ID: <4A01FC3F.7080004@freescale.com> (raw)
In-Reply-To: <fa686aa40905061333q29c263c8p24856c048e30f4d0@mail.gmail.com>
Grant Likely wrote:
>> #ifdef CONFIG_FS_ENET_HAS_FEC
>> +#ifdef CONFIG_FS_ENET_MPC5121_FEC
>> + {
>> + .compatible = "fsl,mpc5121-fec",
>> + .data = (void *)&fs_fec_ops,
>> + },
>> +#else
>> {
>> .compatible = "fsl,pq1-fec-enet",
>> .data = (void *)&fs_fec_ops,
>> },
>> #endif
>> +#endif
>
> Hmmm. A lot of these #ifdefs in here. Does this have a multiplatform
> impact? Not to mention the fact that it's just plain ugly. :-)
Multiplatform between 512x and 8xx is currently impossible for other
reasons (512x and CPM2 is another matter). That said, less ifdefs would
be nice.
-Scott
next prev parent reply other threads:[~2009-05-06 21:08 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 20:15 [PATCH 00/16] Add support for MPC512x Wolfgang Denk
2009-05-06 20:15 ` [PATCH 01/12] fs_enet: Use defines to set driver tunables Wolfgang Denk
2009-05-06 20:15 ` Wolfgang Denk
2009-05-06 20:35 ` Grant Likely
2009-05-06 20:35 ` Grant Likely
2009-05-06 22:02 ` Wolfgang Denk
2009-05-06 22:41 ` Grant Likely
2009-05-06 22:41 ` Grant Likely
2009-05-06 20:15 ` [PATCH 02/12] fs_enet: Add MPC5121 FEC support Wolfgang Denk
2009-05-06 20:15 ` Wolfgang Denk
2009-05-06 20:33 ` Grant Likely
2009-05-06 20:33 ` Grant Likely
2009-05-06 21:08 ` Scott Wood [this message]
2009-05-06 21:08 ` Scott Wood
2009-05-06 22:01 ` Wolfgang Denk
2009-05-06 22:01 ` Wolfgang Denk
2009-05-06 22:29 ` Grant Likely
2009-05-06 22:29 ` Grant Likely
2009-05-06 22:41 ` Wolfgang Denk
2009-05-06 22:41 ` Wolfgang Denk
2009-05-07 14:09 ` Grant Likely
2009-05-07 14:09 ` Grant Likely
2009-05-08 2:02 ` John Rigby
2009-05-08 2:02 ` John Rigby
2009-05-08 7:52 ` David Miller
2009-05-08 7:52 ` David Miller
2009-05-11 6:56 ` David Jander
2009-05-07 8:14 ` David Jander
2009-05-07 13:05 ` Kumar Gala
2009-05-06 20:40 ` David Miller
2009-05-06 20:40 ` David Miller
2009-05-06 22:06 ` Wolfgang Denk
2009-05-06 20:41 ` Scott Wood
2009-05-06 20:41 ` Scott Wood
2009-05-06 22:09 ` Wolfgang Denk
2009-05-06 22:39 ` Grant Likely
2009-05-06 22:39 ` Grant Likely
2009-05-14 12:38 ` Piotr Zięcik
2009-05-14 12:38 ` Piotr Zięcik
2009-05-14 14:00 ` Grant Likely
2009-05-14 14:00 ` Grant Likely
2009-05-18 22:17 ` Benjamin Herrenschmidt
2009-05-19 11:26 ` Piotr Zięcik
2009-05-19 11:26 ` Piotr Zięcik
2009-05-19 21:56 ` Benjamin Herrenschmidt
2009-05-19 21:56 ` Benjamin Herrenschmidt
2009-05-21 8:34 ` Piotr Zięcik
2009-05-21 8:34 ` Piotr Zięcik
2009-05-21 15:36 ` Grant Likely
2009-05-21 15:36 ` Grant Likely
2009-05-06 20:15 ` [PATCH 03/12] fs_enet: Add FEC TX Alignment workaround for MPC5121 Wolfgang Denk
2009-05-06 20:15 ` Wolfgang Denk
2009-05-06 20:37 ` Grant Likely
2009-05-06 20:37 ` Grant Likely
2009-05-06 22:12 ` Wolfgang Denk
2009-05-06 22:42 ` Grant Likely
2009-05-06 22:42 ` Grant Likely
2009-05-08 2:36 ` John Rigby
2009-05-08 2:36 ` John Rigby
2009-05-06 20:15 ` [PATCH 04/12] mpc5121: Added reset module registers representation Wolfgang Denk
2009-05-06 20:29 ` Scott Wood
2009-05-06 21:57 ` Wolfgang Denk
2009-05-06 20:39 ` Grant Likely
2009-05-06 22:14 ` Wolfgang Denk
2009-05-06 20:15 ` [PATCH 05/12] mpc5121ads: Added Reset Module node to DTS Wolfgang Denk
2009-05-06 20:40 ` Grant Likely
2009-05-06 22:16 ` Wolfgang Denk
2009-05-06 22:46 ` Grant Likely
2009-05-06 20:15 ` [PATCH 06/12] mpc5121: Added NAND Flash Controller driver Wolfgang Denk
2009-05-06 20:15 ` Wolfgang Denk
2009-05-06 20:59 ` Grant Likely
2009-05-06 20:59 ` Grant Likely
2009-05-08 2:22 ` John Rigby
2009-05-08 3:07 ` Grant Likely
2009-05-08 3:07 ` Grant Likely
2009-05-07 8:08 ` David Jander
2009-05-07 8:08 ` David Jander
2009-05-08 3:30 ` John Rigby
2009-05-13 8:41 ` Piotr Zięcik
2009-05-13 8:41 ` Piotr Zięcik
2009-05-06 20:15 ` [PATCH 07/12] mpc5121ads: Clean up and fix NAND description in mpc5121ads DTS Wolfgang Denk
2009-05-06 21:00 ` Grant Likely
[not found] ` <1241640919-4650-1-git-send-email-wd-ynQEQJNshbs@public.gmane.org>
2009-05-06 20:15 ` [PATCH 08/12] mpc5121: Added I2C support Wolfgang Denk
2009-05-06 20:15 ` Wolfgang Denk
[not found] ` <1241640919-4650-9-git-send-email-wd-ynQEQJNshbs@public.gmane.org>
2009-05-06 21:01 ` Grant Likely
2009-05-06 21:01 ` Grant Likely
[not found] ` <fa686aa40905061401k319313c5q89fd3e245c30808f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-06 22:19 ` Wolfgang Denk
2009-05-06 22:19 ` Wolfgang Denk
2009-05-06 22:51 ` Grant Likely
[not found] ` <fa686aa40905061551l8cf5940sf4d4cbf34331cf9a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-07 2:41 ` Grant Likely
2009-05-07 2:41 ` Grant Likely
[not found] ` <fa686aa40905061941p6fd4b03dt1097cf4d16bdd665-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-07 6:36 ` Wolfgang Grandegger
2009-05-07 6:36 ` Wolfgang Grandegger
2009-05-18 13:57 ` Piotr Zięcik
2009-05-18 13:57 ` Piotr Zięcik
2009-05-18 14:11 ` Grant Likely
2009-05-18 14:11 ` Grant Likely
[not found] ` <200905181557.11766.kosmo-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
2009-05-18 14:29 ` Wolfgang Grandegger
2009-05-18 14:29 ` Wolfgang Grandegger
[not found] ` <4A1170B0.5080203-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-05-19 7:47 ` Piotr Zięcik
2009-05-19 7:47 ` Piotr Zięcik
2009-05-19 8:10 ` Wolfgang Grandegger
2009-05-08 2:12 ` John Rigby
2009-05-08 2:12 ` John Rigby
2009-05-08 3:01 ` Grant Likely
2009-05-08 3:01 ` Grant Likely
2009-05-06 20:15 ` [PATCH 09/12] mpc5121ads: Added I2C RTC node to mpc5121ads DTS Wolfgang Denk
2009-05-06 21:02 ` Grant Likely
2009-05-07 6:45 ` Wolfgang Grandegger
2009-05-06 20:15 ` [PATCH 10/12] mpc5121: Add MPC5121 Real time clock driver Wolfgang Denk
2009-05-06 21:03 ` Grant Likely
2009-05-06 21:06 ` Wolfram Sang
2009-05-06 22:40 ` Grant Likely
2009-05-08 2:41 ` [rtc-linux] " John Rigby
2009-05-08 15:53 ` Grant Likely
2009-05-08 16:09 ` Alessandro Zummo
2009-05-08 19:18 ` Wolfgang Denk
2009-05-08 16:10 ` Alessandro Zummo
2009-05-06 20:15 ` [PATCH 11/12] mpc5121: Added MPC512x DMA driver Wolfgang Denk
2009-05-06 21:07 ` Grant Likely
2009-05-08 2:49 ` John Rigby
2009-05-19 1:37 ` Hongjun Chen
2009-05-19 8:03 ` Piotr Zięcik
2009-05-20 0:39 ` Hongjun Chen
2009-05-06 20:15 ` [PATCH 12/12] mpc5121: Added default config for MPC5121 Wolfgang Denk
2009-05-06 21:08 ` Grant Likely
2009-05-06 22:23 ` Wolfgang Denk
2009-05-06 22:48 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A01FC3F.7080004@freescale.com \
--to=scottwood@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=jrigby@gmail.com \
--cc=kosmo@semihalf.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.