* [Cluster-devel] [PATCH] dlm_tool: Fix silly error:
@ 2009-05-07 14:29 Chrissie Caulfield
2009-05-07 14:27 ` David Teigland
0 siblings, 1 reply; 3+ messages in thread
From: Chrissie Caulfield @ 2009-05-07 14:29 UTC (permalink / raw)
To: cluster-devel.redhat.com
If you do
# dlm_tool lockdump default
on a lockspace with no locks in it, you get the error message:
can't read /sys/kernel/debug/dlm/default_locks: Success
This patch puts a slightly more sensible error message in place.
Chrissie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dlmtool.patch
Type: text/x-patch
Size: 556 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20090507/790574fd/attachment.bin>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] [PATCH] dlm_tool: Fix silly error:
2009-05-07 14:29 [Cluster-devel] [PATCH] dlm_tool: Fix silly error: Chrissie Caulfield
@ 2009-05-07 14:27 ` David Teigland
2009-05-07 15:11 ` Chrissie Caulfield
0 siblings, 1 reply; 3+ messages in thread
From: David Teigland @ 2009-05-07 14:27 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Thu, May 07, 2009 at 03:29:03PM +0100, Chrissie Caulfield wrote:
> If you do
>
> # dlm_tool lockdump default
>
> on a lockspace with no locks in it, you get the error message:
>
> can't read /sys/kernel/debug/dlm/default_locks: Success
>
> This patch puts a slightly more sensible error message in place.
Ack, thanks, could you also do the same for "lockdebug"?
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] [PATCH] dlm_tool: Fix silly error:
2009-05-07 14:27 ` David Teigland
@ 2009-05-07 15:11 ` Chrissie Caulfield
0 siblings, 0 replies; 3+ messages in thread
From: Chrissie Caulfield @ 2009-05-07 15:11 UTC (permalink / raw)
To: cluster-devel.redhat.com
David Teigland wrote:
> On Thu, May 07, 2009 at 03:29:03PM +0100, Chrissie Caulfield wrote:
>> If you do
>>
>> # dlm_tool lockdump default
>>
>> on a lockspace with no locks in it, you get the error message:
>>
>> can't read /sys/kernel/debug/dlm/default_locks: Success
>>
>> This patch puts a slightly more sensible error message in place.
>
> Ack, thanks, could you also do the same for "lockdebug"?
Or perhaps it would make more sense to simply print noting at all in
that case. That would be consistent with all the other parts of dlm_tool
as well as the "no news is good news" philosophy of Unix tools in general.
--
Chrissie
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-07 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-07 14:29 [Cluster-devel] [PATCH] dlm_tool: Fix silly error: Chrissie Caulfield
2009-05-07 14:27 ` David Teigland
2009-05-07 15:11 ` Chrissie Caulfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.