From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1/4] kvm: Add support for querying supported cpu features
Date: Sat, 09 May 2009 11:41:13 +0300 [thread overview]
Message-ID: <4A0541A9.6060800@redhat.com> (raw)
In-Reply-To: <4A049F96.90502@us.ibm.com>
Anthony Liguori wrote:
> Anthony Liguori wrote:
>>
>> kvm_check_extension doesn't exist in upstream QEMU. It's a good idea
>> though so I added it in a previous commit. However, I changed the
>> signature to it to take a KVMState * as the first argument (which is
>> available in env->kvm_state). I updated this patch to pass the extra
>> 's' parameter.
>
> Ah, you had a patch, I just didn't notice in my queue.
>
Yeah, I should have made the dependency explicit.
> Still wanted to make the KVMState change though.
>
I think the KVM_REQUIRE_EXTENSION bit didn't like it.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH 1/4] kvm: Add support for querying supported cpu features
Date: Sat, 09 May 2009 11:41:13 +0300 [thread overview]
Message-ID: <4A0541A9.6060800@redhat.com> (raw)
In-Reply-To: <4A049F96.90502@us.ibm.com>
Anthony Liguori wrote:
> Anthony Liguori wrote:
>>
>> kvm_check_extension doesn't exist in upstream QEMU. It's a good idea
>> though so I added it in a previous commit. However, I changed the
>> signature to it to take a KVMState * as the first argument (which is
>> available in env->kvm_state). I updated this patch to pass the extra
>> 's' parameter.
>
> Ah, you had a patch, I just didn't notice in my queue.
>
Yeah, I should have made the dependency explicit.
> Still wanted to make the KVMState change though.
>
I think the KVM_REQUIRE_EXTENSION bit didn't like it.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-05-09 8:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 14:04 [PATCH 0/4] Fix kvm cpuid reporting Avi Kivity
2009-05-03 14:04 ` [Qemu-devel] " Avi Kivity
2009-05-03 14:04 ` [PATCH 1/4] kvm: Add support for querying supported cpu features Avi Kivity
2009-05-03 14:04 ` [Qemu-devel] " Avi Kivity
2009-05-08 20:50 ` Anthony Liguori
2009-05-08 20:50 ` [Qemu-devel] " Anthony Liguori
2009-05-08 21:09 ` Anthony Liguori
2009-05-08 21:09 ` [Qemu-devel] " Anthony Liguori
2009-05-09 8:41 ` Avi Kivity [this message]
2009-05-09 8:41 ` Avi Kivity
2009-05-03 14:04 ` [PATCH 2/4] Make x86 cpuid feature names available in file scope Avi Kivity
2009-05-03 14:04 ` [Qemu-devel] " Avi Kivity
2009-05-03 14:04 ` [PATCH 3/4] Fix x86 feature modifications for features that set multiple bits Avi Kivity
2009-05-03 14:04 ` [Qemu-devel] " Avi Kivity
2009-05-03 14:04 ` [PATCH 4/4] kvm: Trim cpu features not supported by kvm Avi Kivity
2009-05-03 14:04 ` [Qemu-devel] " Avi Kivity
2009-05-12 11:52 ` Mark McLoughlin
2009-05-12 11:52 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0541A9.6060800@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.