* [RESEND][PATCH 1/4] pxa2xx-i2s: Proper initialization
@ 2009-05-11 21:49 Karl Beldan
2009-05-12 14:52 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Karl Beldan @ 2009-05-11 21:49 UTC (permalink / raw)
To: Mark Brown
Cc: Eric Miao, alsa-devel, Russell King, linux-arm-kernel email list
Reset FIFO logic and registers, and make sure REC and RPL functions along
with FIFO service are disabled at probe.
Signed-off-by: Karl Beldan <karl.beldan@mobile-devices.fr>
---
sound/soc/pxa/pxa2xx-i2s.c | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/sound/soc/pxa/pxa2xx-i2s.c b/sound/soc/pxa/pxa2xx-i2s.c
index 2f4b6e4..450fca6 100644
--- a/sound/soc/pxa/pxa2xx-i2s.c
+++ b/sound/soc/pxa/pxa2xx-i2s.c
@@ -346,6 +346,19 @@ static int pxa2xx_i2s_probe(struct platform_device *dev)
if (ret != 0)
clk_put(clk_i2s);
+ /*
+ * PXA Developer's Manual:
+ * If SACR0[ENB] is toggled in the middle of a normal operation,
+ * the SACR0[RST] bit must also be set and cleared to reset all
+ * I2S controller registers.
+ */
+ SACR0 = SACR0_RST;
+ SACR0 = 0;
+ /* Make sure RPL and REC are disabled */
+ SACR1 = SACR1_DRPL | SACR1_DREC;
+ /* Along with FIFO servicing */
+ SAIMR &= ~(SAIMR_RFS | SAIMR_TFS);
+
return ret;
}
--
1.6.3.rc1.34.g0be9b
--
Karl Beldan
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND][PATCH 1/4] pxa2xx-i2s: Proper initialization
2009-05-11 21:49 [RESEND][PATCH 1/4] pxa2xx-i2s: Proper initialization Karl Beldan
@ 2009-05-12 14:52 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2009-05-12 14:52 UTC (permalink / raw)
To: Karl Beldan
Cc: Russell King, alsa-devel, Eric Miao, linux-arm-kernel email list
On Mon, May 11, 2009 at 11:49:41PM +0200, Karl Beldan wrote:
> Reset FIFO logic and registers, and make sure REC and RPL functions along
> with FIFO service are disabled at probe.
>
> Signed-off-by: Karl Beldan <karl.beldan@mobile-devices.fr>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-12 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-11 21:49 [RESEND][PATCH 1/4] pxa2xx-i2s: Proper initialization Karl Beldan
2009-05-12 14:52 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.