* [PATCH] sctp: avoid overwrite the return value of sctp_process_asconf_ack()
@ 2009-05-12 13:57 Wei Yongjun
2009-05-12 16:08 ` Vlad Yasevich
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2009-05-12 13:57 UTC (permalink / raw)
To: linux-sctp
The return value of sctp_process_asconf_ack() may be
overwritten while process parameters with no error.
This patch fixed the problem.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/sctp/sm_make_chunk.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index ab91712..06ad732 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -3271,7 +3271,8 @@ int sctp_process_asconf_ack(struct sctp_association *asoc,
switch (err_code) {
case SCTP_ERROR_NO_ERROR:
- retval = sctp_asconf_param_success(asoc, asconf_param);
+ if (sctp_asconf_param_success(asoc, asconf_param))
+ retval = 1;
break;
case SCTP_ERROR_RSRC_LOW:
--
1.5.3.8
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sctp: avoid overwrite the return value of sctp_process_asconf_ack()
2009-05-12 13:57 [PATCH] sctp: avoid overwrite the return value of sctp_process_asconf_ack() Wei Yongjun
@ 2009-05-12 16:08 ` Vlad Yasevich
0 siblings, 0 replies; 2+ messages in thread
From: Vlad Yasevich @ 2009-05-12 16:08 UTC (permalink / raw)
To: linux-sctp
Wei Yongjun wrote:
> The return value of sctp_process_asconf_ack() may be
> overwritten while process parameters with no error.
> This patch fixed the problem.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> ---
> net/sctp/sm_make_chunk.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index ab91712..06ad732 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -3271,7 +3271,8 @@ int sctp_process_asconf_ack(struct sctp_association *asoc,
>
> switch (err_code) {
> case SCTP_ERROR_NO_ERROR:
> - retval = sctp_asconf_param_success(asoc, asconf_param);
> + if (sctp_asconf_param_success(asoc, asconf_param))
> + retval = 1;
> break;
>
> case SCTP_ERROR_RSRC_LOW:
Hmm... As long as you are cleaning up, looks like sctp_asconf_param_success
can easily become a void and we avoid this whole thing. Right now, that function
will never return 'TRUE'.
-vlad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-12 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-12 13:57 [PATCH] sctp: avoid overwrite the return value of sctp_process_asconf_ack() Wei Yongjun
2009-05-12 16:08 ` Vlad Yasevich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.