* [PATCH] sctp: check the unrecognized ASCONF parameter before access
@ 2009-05-12 13:59 Wei Yongjun
2009-05-12 16:14 ` [PATCH] sctp: check the unrecognized ASCONF parameter before Vlad Yasevich
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2009-05-12 13:59 UTC (permalink / raw)
To: linux-sctp
This patch fix to check the unrecognized ASCONF parameter before
access it.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/sctp/sm_make_chunk.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 61cc607..ab91712 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -2861,6 +2861,11 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
addr_param = (union sctp_addr_param *)
((void *)asconf_param + sizeof(sctp_addip_param_t));
+ if (asconf_param->param_hdr.type != SCTP_PARAM_ADD_IP &&
+ asconf_param->param_hdr.type != SCTP_PARAM_DEL_IP &&
+ asconf_param->param_hdr.type != SCTP_PARAM_SET_PRIMARY)
+ return SCTP_ERROR_UNKNOWN_PARAM;
+
switch (addr_param->v4.param_hdr.type) {
case SCTP_PARAM_IPV6_ADDRESS:
if (!asoc->peer.ipv6_address)
--
1.5.3.8
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sctp: check the unrecognized ASCONF parameter before
2009-05-12 13:59 [PATCH] sctp: check the unrecognized ASCONF parameter before access Wei Yongjun
@ 2009-05-12 16:14 ` Vlad Yasevich
0 siblings, 0 replies; 2+ messages in thread
From: Vlad Yasevich @ 2009-05-12 16:14 UTC (permalink / raw)
To: linux-sctp
Wei Yongjun wrote:
> This patch fix to check the unrecognized ASCONF parameter before
> access it.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> ---
> net/sctp/sm_make_chunk.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 61cc607..ab91712 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -2861,6 +2861,11 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
> addr_param = (union sctp_addr_param *)
> ((void *)asconf_param + sizeof(sctp_addip_param_t));
>
> + if (asconf_param->param_hdr.type != SCTP_PARAM_ADD_IP &&
> + asconf_param->param_hdr.type != SCTP_PARAM_DEL_IP &&
> + asconf_param->param_hdr.type != SCTP_PARAM_SET_PRIMARY)
> + return SCTP_ERROR_UNKNOWN_PARAM;
> +
> switch (addr_param->v4.param_hdr.type) {
> case SCTP_PARAM_IPV6_ADDRESS:
> if (!asoc->peer.ipv6_address)
Clean up the 'default' case, since it now becomes dead code.
-vlad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-12 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-12 13:59 [PATCH] sctp: check the unrecognized ASCONF parameter before access Wei Yongjun
2009-05-12 16:14 ` [PATCH] sctp: check the unrecognized ASCONF parameter before Vlad Yasevich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.