All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Barinov <vbarinov@embeddedalley.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	Linux MTD list <linux-mtd@lists.infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: mxc_nand: fix built breakage
Date: Wed, 13 May 2009 20:09:43 +0400	[thread overview]
Message-ID: <4A0AF0C7.5090104@embeddedalley.com> (raw)
In-Reply-To: <1242229410-11853-1-git-send-email-daniel@caiaq.de>

Hello Daniel,

Please find the patch that I've sent some time ago. This patch should 
fix the issue you described.
http://lists.infradead.org/pipermail/linux-mtd/2009-April/025363.html

Vladimir

Daniel Mack wrote:
> The MXC NAND driver does not currently build with CONFIG_PM set.
>
>   drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_suspend':
>   drivers/mtd/nand/mxc_nand.c:1021: error: 'nfc_clk' undeclared (first use in this function)
>   drivers/mtd/nand/mxc_nand.c:1021: error: (Each undeclared identifier is reported only once
>   drivers/mtd/nand/mxc_nand.c:1021: error: for each function it appears in.)
>   drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_resume':
>   drivers/mtd/nand/mxc_nand.c:1033: error: 'nfc_clk' undeclared (first use in this function)
>   make[3]: *** [drivers/mtd/nand/mxc_nand.o] Error 1
>   make[2]: *** [drivers/mtd/nand] Error 2
>   make[1]: *** [drivers/mtd] Error 2
>   make: *** [drivers] Error 2
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Linux MTD list <linux-mtd@lists.infradead.org>
> ---
>  drivers/mtd/nand/mxc_nand.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 21fd4f1..d352d2a 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -1011,6 +1011,8 @@ static int __devexit mxcnd_remove(struct platform_device *pdev)
>  static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state)
>  {
>  	struct mtd_info *info = platform_get_drvdata(pdev);
> +        struct nand_chip *nand_chip = info->priv;
>   
> +	struct mxc_nand_host *host = nand_chip->priv;
>  	int ret = 0;
>  
>  	DEBUG(MTD_DEBUG_LEVEL0, "MXC_ND : NAND suspend\n");
> @@ -1018,7 +1020,7 @@ static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state)
>  		ret = info->suspend(info);
>  
>  	/* Disable the NFC clock */
> -	clk_disable(nfc_clk);	/* FIXME */
> +	clk_disable(host->clk);	/* FIXME */
>  
>  	return ret;
>  }
> @@ -1026,11 +1028,13 @@ static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state)
>  static int mxcnd_resume(struct platform_device *pdev)
>  {
>  	struct mtd_info *info = platform_get_drvdata(pdev);
> +        struct nand_chip *nand_chip = info->priv;
> +	struct mxc_nand_host *host = nand_chip->priv;
>  	int ret = 0;
>  
>  	DEBUG(MTD_DEBUG_LEVEL0, "MXC_ND : NAND resume\n");
>  	/* Enable the NFC clock */
> -	clk_enable(nfc_clk);	/* FIXME */
> +	clk_enable(host->clk);	/* FIXME */
>  
>  	if (info)
>  		info->resume(info);
>   

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Barinov <vbarinov@embeddedalley.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Linux MTD list <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] mtd: mxc_nand: fix built breakage
Date: Wed, 13 May 2009 20:09:43 +0400	[thread overview]
Message-ID: <4A0AF0C7.5090104@embeddedalley.com> (raw)
In-Reply-To: <1242229410-11853-1-git-send-email-daniel@caiaq.de>

Hello Daniel,

Please find the patch that I've sent some time ago. This patch should 
fix the issue you described.
http://lists.infradead.org/pipermail/linux-mtd/2009-April/025363.html

Vladimir

Daniel Mack wrote:
> The MXC NAND driver does not currently build with CONFIG_PM set.
>
>   drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_suspend':
>   drivers/mtd/nand/mxc_nand.c:1021: error: 'nfc_clk' undeclared (first use in this function)
>   drivers/mtd/nand/mxc_nand.c:1021: error: (Each undeclared identifier is reported only once
>   drivers/mtd/nand/mxc_nand.c:1021: error: for each function it appears in.)
>   drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_resume':
>   drivers/mtd/nand/mxc_nand.c:1033: error: 'nfc_clk' undeclared (first use in this function)
>   make[3]: *** [drivers/mtd/nand/mxc_nand.o] Error 1
>   make[2]: *** [drivers/mtd/nand] Error 2
>   make[1]: *** [drivers/mtd] Error 2
>   make: *** [drivers] Error 2
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Linux MTD list <linux-mtd@lists.infradead.org>
> ---
>  drivers/mtd/nand/mxc_nand.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 21fd4f1..d352d2a 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -1011,6 +1011,8 @@ static int __devexit mxcnd_remove(struct platform_device *pdev)
>  static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state)
>  {
>  	struct mtd_info *info = platform_get_drvdata(pdev);
> +        struct nand_chip *nand_chip = info->priv;
>   
> +	struct mxc_nand_host *host = nand_chip->priv;
>  	int ret = 0;
>  
>  	DEBUG(MTD_DEBUG_LEVEL0, "MXC_ND : NAND suspend\n");
> @@ -1018,7 +1020,7 @@ static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state)
>  		ret = info->suspend(info);
>  
>  	/* Disable the NFC clock */
> -	clk_disable(nfc_clk);	/* FIXME */
> +	clk_disable(host->clk);	/* FIXME */
>  
>  	return ret;
>  }
> @@ -1026,11 +1028,13 @@ static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state)
>  static int mxcnd_resume(struct platform_device *pdev)
>  {
>  	struct mtd_info *info = platform_get_drvdata(pdev);
> +        struct nand_chip *nand_chip = info->priv;
> +	struct mxc_nand_host *host = nand_chip->priv;
>  	int ret = 0;
>  
>  	DEBUG(MTD_DEBUG_LEVEL0, "MXC_ND : NAND resume\n");
>  	/* Enable the NFC clock */
> -	clk_enable(nfc_clk);	/* FIXME */
> +	clk_enable(host->clk);	/* FIXME */
>  
>  	if (info)
>  		info->resume(info);
>   


  parent reply	other threads:[~2009-05-13 16:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13 15:43 [PATCH] mtd: mxc_nand: fix built breakage Daniel Mack
2009-05-13 15:43 ` Daniel Mack
2009-05-13 15:47 ` Daniel Mack
2009-05-13 16:09 ` Vladimir Barinov [this message]
2009-05-13 16:09   ` Vladimir Barinov
2009-05-13 16:11   ` Daniel Mack
2009-05-13 16:11     ` Daniel Mack
2009-05-14  6:56     ` Sascha Hauer
2009-05-14  6:56       ` Sascha Hauer
2009-05-14  7:01       ` Artem Bityutskiy
2009-05-14  7:01         ` Artem Bityutskiy
2009-05-14  7:45         ` Sascha Hauer
2009-05-14  7:45           ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0AF0C7.5090104@embeddedalley.com \
    --to=vbarinov@embeddedalley.com \
    --cc=daniel@caiaq.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.