From: Izik Eidus <ieidus@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kvm@vger.kernel.org, avi@redhat.com, aarcange@redhat.com,
chrisw@redhat.com, mtosatti@redhat.com, hugh@veritas.com
Subject: Re: [PATCH 5/5] add ksm kernel shared memory driver.
Date: Thu, 14 May 2009 03:15:05 +0300 [thread overview]
Message-ID: <4A0B6289.2000502@redhat.com> (raw)
In-Reply-To: <20090513161739.d801ab67.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Mon, 20 Apr 2009 04:36:06 +0300
> Izik Eidus <ieidus@redhat.com> wrote:
>
>
>> Ksm is driver that allow merging identical pages between one or more
>> applications in way unvisible to the application that use it.
>> Pages that are merged are marked as readonly and are COWed when any
>> application try to change them.
>>
>> Ksm is used for cases where using fork() is not suitable,
>> one of this cases is where the pages of the application keep changing
>> dynamicly and the application cannot know in advance what pages are
>> going to be identical.
>>
>> Ksm works by walking over the memory pages of the applications it
>> scan in order to find identical pages.
>> It uses a two sorted data strctures called stable and unstable trees
>> to find in effective way the identical pages.
>>
>> When ksm finds two identical pages, it marks them as readonly and merges
>> them into single one page,
>> after the pages are marked as readonly and merged into one page, linux
>> will treat this pages as normal copy_on_write pages and will fork them
>> when write access will happen to them.
>>
>> Ksm scan just memory areas that were registred to be scanned by it.
>>
>> ...
>> + copy_user_highpage(kpage, page1, addr1, vma);
>> ...
>>
>
> Breaks ppc64 allmodcofnig because that architecture doesn't export its
> copy_user_page() to modules.
>
> Architectures are inconsistent about this. x86 _does_ export it,
> because it bounces it to the exported copy_page().
>
> So can I ask that you sit down and work out upon which architectures it
> really makes sense to offer KSM? Disallow the others in Kconfig and
> arrange for copy_user_highpage() to be available on the allowed architectures?
>
Hi
There is some way (script) that i can run that will allow compile this
code for every possible arch?
(I dont mind to allow it just for archs that support virtualization -
x86, ia64, powerpc, s390, but is it the right thing to do ?)
> Thanks.
>
WARNING: multiple messages have this Message-ID (diff)
From: Izik Eidus <ieidus@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kvm@vger.kernel.org, avi@redhat.com, aarcange@redhat.com,
chrisw@redhat.com, mtosatti@redhat.com, hugh@veritas.com
Subject: Re: [PATCH 5/5] add ksm kernel shared memory driver.
Date: Thu, 14 May 2009 03:15:05 +0300 [thread overview]
Message-ID: <4A0B6289.2000502@redhat.com> (raw)
In-Reply-To: <20090513161739.d801ab67.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Mon, 20 Apr 2009 04:36:06 +0300
> Izik Eidus <ieidus@redhat.com> wrote:
>
>
>> Ksm is driver that allow merging identical pages between one or more
>> applications in way unvisible to the application that use it.
>> Pages that are merged are marked as readonly and are COWed when any
>> application try to change them.
>>
>> Ksm is used for cases where using fork() is not suitable,
>> one of this cases is where the pages of the application keep changing
>> dynamicly and the application cannot know in advance what pages are
>> going to be identical.
>>
>> Ksm works by walking over the memory pages of the applications it
>> scan in order to find identical pages.
>> It uses a two sorted data strctures called stable and unstable trees
>> to find in effective way the identical pages.
>>
>> When ksm finds two identical pages, it marks them as readonly and merges
>> them into single one page,
>> after the pages are marked as readonly and merged into one page, linux
>> will treat this pages as normal copy_on_write pages and will fork them
>> when write access will happen to them.
>>
>> Ksm scan just memory areas that were registred to be scanned by it.
>>
>> ...
>> + copy_user_highpage(kpage, page1, addr1, vma);
>> ...
>>
>
> Breaks ppc64 allmodcofnig because that architecture doesn't export its
> copy_user_page() to modules.
>
> Architectures are inconsistent about this. x86 _does_ export it,
> because it bounces it to the exported copy_page().
>
> So can I ask that you sit down and work out upon which architectures it
> really makes sense to offer KSM? Disallow the others in Kconfig and
> arrange for copy_user_highpage() to be available on the allowed architectures?
>
Hi
There is some way (script) that i can run that will allow compile this
code for every possible arch?
(I dont mind to allow it just for archs that support virtualization -
x86, ia64, powerpc, s390, but is it the right thing to do ?)
> Thanks.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-14 0:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 1:36 [PATCH 0/5] ksm - dynamic page sharing driver for linux v4 Izik Eidus
2009-04-20 1:36 ` Izik Eidus
2009-04-20 1:36 ` [PATCH 1/5] MMU_NOTIFIERS: add set_pte_at_notify() Izik Eidus
2009-04-20 1:36 ` Izik Eidus
2009-04-20 1:36 ` [PATCH 2/5] add get_pte(): helper function: fetching pte for va Izik Eidus
2009-04-20 1:36 ` Izik Eidus
2009-04-20 1:36 ` [PATCH 3/5] add page_wrprotect(): write protecting page Izik Eidus
2009-04-20 1:36 ` Izik Eidus
2009-04-20 1:36 ` [PATCH 4/5] add replace_page(): change the page pte is pointing to Izik Eidus
2009-04-20 1:36 ` Izik Eidus
2009-04-20 1:36 ` [PATCH 5/5] add ksm kernel shared memory driver Izik Eidus
2009-04-20 1:36 ` Izik Eidus
2009-04-20 10:02 ` Alan Cox
2009-04-20 10:02 ` Alan Cox
2009-04-20 10:02 ` Alan Cox
2009-04-20 11:11 ` Avi Kivity
2009-04-20 11:11 ` Avi Kivity
2009-04-20 12:52 ` Izik Eidus
2009-04-20 12:52 ` Izik Eidus
2009-04-27 22:34 ` Andrew Morton
2009-04-27 22:34 ` Andrew Morton
2009-04-27 22:34 ` Andrew Morton
2009-04-27 23:12 ` Izik Eidus
2009-04-27 23:12 ` Izik Eidus
2009-04-30 17:46 ` Izik Eidus
2009-04-30 17:46 ` Izik Eidus
2009-04-30 17:58 ` Andrew Morton
2009-04-30 17:58 ` Andrew Morton
2009-05-13 23:17 ` Andrew Morton
2009-05-13 23:17 ` Andrew Morton
2009-05-13 23:17 ` Andrew Morton
2009-05-13 23:25 ` Chris Wright
2009-05-13 23:25 ` Chris Wright
2009-05-14 0:14 ` Anthony Liguori
2009-05-14 0:14 ` Anthony Liguori
2009-05-14 0:11 ` Izik Eidus
2009-05-14 0:11 ` Izik Eidus
2009-05-14 0:15 ` Izik Eidus [this message]
2009-05-14 0:15 ` Izik Eidus
2009-05-14 1:40 ` Tony Breeds
2009-05-14 1:40 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0B6289.2000502@redhat.com \
--to=ieidus@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=chrisw@redhat.com \
--cc=hugh@veritas.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.