Re: [PATCH 1/5] mtd: nand: move layout structure into nand_ecc_ctrl

[Troy Kisky <troy.kisky@boundarydevices.com>]

David Brownell wrote:
> On Wednesday 13 May 2009, Troy Kisky wrote:
>> +static const struct nand_ecclayout atmel_oobinfo_large __initdata = {
> 
> Doesn't this give you section warnings?  __initconst is what
> I usually end up needing in such cases...

Only if the same file has a non const __initdata variable.
Is __initconst the preferred method ?

> 
> Also, for the davinci_nand driver this is going to need to
> switch away from the ecclayout struct in the driver-private
> area ... that's in a patch that (still) hasn't merged into
> the MTD tree, but was stored there for the same reason that
> you're submitting this patch:  the original code, using the
> annoying ECC_HW_SYNDROME support, computed the layout.
> 
> - Dave

Is ECC_HW_SYNDROME only needed because the eccpos array is too small??

I'll have to review that prepad  and ECC_HW_SYNDROME
Thanks

Troy