From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: David Brownell <david-b@pacbell.net>,
Nicolas Ferre <nicolas.ferre@rfo.atmel.com>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 3/5] mtd: nand: atmel: use default ecc layout
Date: Fri, 15 May 2009 16:04:13 -0700 [thread overview]
Message-ID: <4A0DF4ED.6080704@boundarydevices.com> (raw)
In-Reply-To: <80b317760905151538g7572190ahaffc2e22b73a0f9@mail.gmail.com>
Richard Genoud wrote:
> 2009/5/16 Troy Kisky <troy.kisky@boundarydevices.com>:
>> I think you are wrong. It is definitely not what I intended.
>> The logic should say, "If I can place the ecc at the beginning I will,
>> otherwise, I will place it at the end." With the bad block marker
>> at 0, it should choose the end.
>>
>> Troy
>>
> You're right, I missed that.
> So, for atmel_nand, nothing changes, and the hardware ecc code will
> still be correct.
> Maybe you could add a little comment in the code explaining the logic,
> as you just did.
>
> Acked-by: Richard Genoud <richard.genoud@gmail.com>
Ok, I will. Thanks for the review.
Troy
next prev parent reply other threads:[~2009-05-15 23:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1242270008-1552-1-git-send-email-troy.kisky@boundarydevices.com>
2009-05-14 4:42 ` [PATCH 1/5] mtd: nand: move layout structure into nand_ecc_ctrl David Brownell
2009-05-14 17:53 ` Troy Kisky
2009-05-14 18:08 ` David Brownell
[not found] ` <1242270008-1552-2-git-send-email-troy.kisky@boundarydevices.com>
2009-05-14 5:10 ` [PATCH 2/5] mtd: nand: Calculate better default ecc layout David Brownell
2009-05-14 17:59 ` Troy Kisky
[not found] ` <1242270008-1552-3-git-send-email-troy.kisky@boundarydevices.com>
2009-05-14 5:12 ` [PATCH 3/5] mtd: nand: atmel: use " David Brownell
2009-05-14 8:23 ` Haavard Skinnemoen
2009-05-14 18:08 ` Troy Kisky
2009-05-15 7:26 ` Richard Genoud
2009-05-15 19:57 ` Richard Genoud
2009-05-15 22:15 ` Troy Kisky
2009-05-15 22:38 ` Richard Genoud
2009-05-15 23:04 ` Troy Kisky [this message]
2009-05-14 18:04 ` Troy Kisky
2009-05-20 15:19 ` Nicolas Ferre
2009-05-20 18:28 ` Troy Kisky
[not found] ` <1242270008-1552-4-git-send-email-troy.kisky@boundarydevices.com>
2009-05-14 5:18 ` [PATCH 4/5] mtd: nand: cafe_nand: " David Brownell
2009-05-14 21:18 ` Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0DF4ED.6080704@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=david-b@pacbell.net \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@rfo.atmel.com \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.