* [PATCH] IP32 power button fix for 2.6.30
@ 2009-05-14 18:29 Andrew Randrianasulu
2009-05-15 9:13 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Randrianasulu @ 2009-05-14 18:29 UTC (permalink / raw)
To: linux-mips
I think i run into same sort of problem, as described here:
http://lkml.org/lkml/2009/4/16/24
http://lkml.org/lkml/2009/4/14/94
(in my case it was hang after pressing O2's power button)
this patch fixes it:
----
diff --git a/arch/mips/sgi-ip32/ip32-reset.c b/arch/mips/sgi-ip32/ip32-reset.c
index b6cab08..667da93 100644
--- a/arch/mips/sgi-ip32/ip32-reset.c
+++ b/arch/mips/sgi-ip32/ip32-reset.c
@@ -145,7 +145,7 @@ static irqreturn_t ip32_rtc_int(int irq, void *dev_id)
"%s: RTC IRQ without RTC_IRQF\n", __func__);
}
/* Wait until interrupt goes away */
- disable_irq(MACEISA_RTC_IRQ);
+ disable_irq_nosync(MACEISA_RTC_IRQ);
init_timer(&debounce_timer);
debounce_timer.function = debounce;
debounce_timer.expires = jiffies + 50;
----
tested with 2.6.30-rc5 mainline (linux-mips.org tree was also affected)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] IP32 power button fix for 2.6.30
2009-05-14 18:29 [PATCH] IP32 power button fix for 2.6.30 Andrew Randrianasulu
@ 2009-05-15 9:13 ` Ralf Baechle
2009-05-15 9:20 ` Dmitri Vorobiev
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2009-05-15 9:13 UTC (permalink / raw)
To: Andrew Randrianasulu; +Cc: linux-mips
On Thu, May 14, 2009 at 11:29:27AM -0700, Andrew Randrianasulu wrote:
> X-Mailer: YahooMailClassic/5.2.20 YahooMailWebService/0.7.289.1
> I think i run into same sort of problem, as described here:
>
> http://lkml.org/lkml/2009/4/16/24
> http://lkml.org/lkml/2009/4/14/94
>
> (in my case it was hang after pressing O2's power button)
>
> this patch fixes it:
>
> ----
>
> diff --git a/arch/mips/sgi-ip32/ip32-reset.c b/arch/mips/sgi-ip32/ip32-reset.c
> index b6cab08..667da93 100644
> --- a/arch/mips/sgi-ip32/ip32-reset.c
> +++ b/arch/mips/sgi-ip32/ip32-reset.c
> @@ -145,7 +145,7 @@ static irqreturn_t ip32_rtc_int(int irq, void *dev_id)
> "%s: RTC IRQ without RTC_IRQF\n", __func__);
> }
> /* Wait until interrupt goes away */
> - disable_irq(MACEISA_RTC_IRQ);
> + disable_irq_nosync(MACEISA_RTC_IRQ);
> init_timer(&debounce_timer);
> debounce_timer.function = debounce;
> debounce_timer.expires = jiffies + 50;
- no Signed-off-by: line
- whitespace garbled. Use a proper mail client such as /bin/mail ;-)
Grumblingly applied,
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IP32 power button fix for 2.6.30
2009-05-15 9:13 ` Ralf Baechle
@ 2009-05-15 9:20 ` Dmitri Vorobiev
0 siblings, 0 replies; 3+ messages in thread
From: Dmitri Vorobiev @ 2009-05-15 9:20 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Andrew Randrianasulu, linux-mips
Ralf Baechle wrote:
> Use a proper mail client such as /bin/mail ;-)
Err... Maybe it's still too hard to not wrap /usr/bin/git-send-email around /bin/mail ;-)
Dmitri
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-15 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-14 18:29 [PATCH] IP32 power button fix for 2.6.30 Andrew Randrianasulu
2009-05-15 9:13 ` Ralf Baechle
2009-05-15 9:20 ` Dmitri Vorobiev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.