From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: xen-devel@lists.xensource.com, Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] xen/blkfront: allow xenbus state transition to Closing->Closed when not Connected.
Date: Mon, 18 May 2009 11:41:48 -0700 [thread overview]
Message-ID: <4A11ABEC.4050301@goop.org> (raw)
In-Reply-To: <20090518183420.GO4140@kernel.dk>
Jens Axboe wrote:
> On Mon, May 18 2009, Jeremy Fitzhardinge wrote:
>
>> Ian Campbell wrote:
>>
>>> This situation can occur when attempting to attach a block device whose backend
>>> is an empty physical CD-ROM driver. The backend in this case will go directly
>>> from the Initialising state to Closing->Closed. Previously this would result in
>>> a NULL pointer deref on info->gd (xenbus_dev_fatal does not return as a1a15ac5
>>> seems to expect)
>>>
>>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>> Cc: Jeremy Fitzhardinge <jeremy@goop.org>
>>>
>>>
>> Jens, does this look OK to you?
>>
>> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>>
>
> Looks fine, shall I add it for 2.6.30? Does it need a stable backport?
>
Yes please, and for .29. As far as I know there's been no change to
blkfront, so it should apply as-is.
There's another patch to go with it that I'm just having a closer look
at. I'll probably send it your way shortly.
Thanks,
J
prev parent reply other threads:[~2009-05-18 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 12:48 [GIT] blkfront warning and crash fixes Ian Campbell
2009-05-18 12:49 ` [PATCH] xen/blkfront: fix warning when deleting gendisk on unplug/shutdown Ian Campbell
2009-05-18 19:11 ` Jeremy Fitzhardinge
2009-05-19 6:28 ` Jens Axboe
2009-05-18 12:49 ` [PATCH] xen/blkfront: allow xenbus state transition to Closing->Closed when not Connected Ian Campbell
2009-05-18 17:23 ` Jeremy Fitzhardinge
2009-05-18 18:34 ` Jens Axboe
2009-05-18 18:41 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A11ABEC.4050301@goop.org \
--to=jeremy@goop.org \
--cc=ian.campbell@citrix.com \
--cc=jens.axboe@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.