From: Stefan Raspl <raspl@linux.vnet.ibm.com>
To: mingo@redhat.com, Li Zefan <lizf@cn.fujitsu.com>,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
linux-btrace@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [Patch updated] blktrace: remove debugfs entries on bad path
Date: Tue, 19 May 2009 07:59:08 +0000 [thread overview]
Message-ID: <4A1266CC.5040801@linux.vnet.ibm.com> (raw)
debugfs directory entries for devices are not removed on some
of the failure pathes in do_blk_trace_setup().
One way to reproduce is to start blktrace on multiple devices
with insufficient Vmalloc space: Devices will fail with
a message like this:
BLKTRACESETUP(2) /dev/sdu failed: 5/Input/output error
If so, the respective entries in debugfs
(e.g. /sys/kernel/debug/block/sdu) will remain and subsequent
attempts to start blktrace on the respective devices will not
succeed due to existing directories.
Acked-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Stefan Raspl <stefan.raspl@linux.vnet.ibm.com>
---
kernel/trace/blktrace.c | 1 +
1 file changed, 1 insertion(+)
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -262,6 +262,7 @@ static void blk_trace_free(struct blk_tr
{
debugfs_remove(bt->msg_file);
debugfs_remove(bt->dropped_file);
+ debugfs_remove(bt->dir);
relay_close(bt->rchan);
free_percpu(bt->sequence);
free_percpu(bt->msg_data);
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Raspl <raspl@linux.vnet.ibm.com>
To: mingo@redhat.com, Li Zefan <lizf@cn.fujitsu.com>,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
linux-btrace@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [Patch updated] blktrace: remove debugfs entries on bad path
Date: Tue, 19 May 2009 09:59:08 +0200 [thread overview]
Message-ID: <4A1266CC.5040801@linux.vnet.ibm.com> (raw)
debugfs directory entries for devices are not removed on some
of the failure pathes in do_blk_trace_setup().
One way to reproduce is to start blktrace on multiple devices
with insufficient Vmalloc space: Devices will fail with
a message like this:
BLKTRACESETUP(2) /dev/sdu failed: 5/Input/output error
If so, the respective entries in debugfs
(e.g. /sys/kernel/debug/block/sdu) will remain and subsequent
attempts to start blktrace on the respective devices will not
succeed due to existing directories.
Acked-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Stefan Raspl <stefan.raspl@linux.vnet.ibm.com>
---
kernel/trace/blktrace.c | 1 +
1 file changed, 1 insertion(+)
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -262,6 +262,7 @@ static void blk_trace_free(struct blk_tr
{
debugfs_remove(bt->msg_file);
debugfs_remove(bt->dropped_file);
+ debugfs_remove(bt->dir);
relay_close(bt->rchan);
free_percpu(bt->sequence);
free_percpu(bt->msg_data);
next reply other threads:[~2009-05-19 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 7:59 Stefan Raspl [this message]
2009-05-19 7:59 ` [Patch updated] blktrace: remove debugfs entries on bad path Stefan Raspl
2009-05-19 8:31 ` [tip:tracing/core] " tip-bot for Stefan Raspl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1266CC.5040801@linux.vnet.ibm.com \
--to=raspl@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.