From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume.
Date: Tue, 19 May 2009 14:17:22 -0700 [thread overview]
Message-ID: <4A1321E2.7000500@oracle.com> (raw)
In-Reply-To: <1242686840-19116-1-git-send-email-tao.ma@oracle.com>
Tao Ma wrote:
> No need for nonsense "goto leave" in the end of ocfs2_mount_volume.
>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
>
Remove redundant gotos in ocfs2_mount_volume().
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
> ---
> fs/ocfs2/super.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 79ff8d9..4601a57 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1766,13 +1766,8 @@ static int ocfs2_mount_volume(struct super_block *sb)
> }
>
> status = ocfs2_truncate_log_init(osb);
> - if (status < 0) {
> + if (status < 0)
> mlog_errno(status);
> - goto leave;
> - }
> -
> - if (ocfs2_mount_local(osb))
> - goto leave;
>
> leave:
> if (unlock_super)
>
next prev parent reply other threads:[~2009-05-19 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 22:47 [Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume Tao Ma
2009-05-19 21:17 ` Sunil Mushran [this message]
2009-06-04 2:24 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1321E2.7000500@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.