* [Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume.
@ 2009-05-18 22:47 Tao Ma
2009-05-19 21:17 ` Sunil Mushran
2009-06-04 2:24 ` Joel Becker
0 siblings, 2 replies; 3+ messages in thread
From: Tao Ma @ 2009-05-18 22:47 UTC (permalink / raw)
To: ocfs2-devel
No need for nonsense "goto leave" in the end of ocfs2_mount_volume.
Signed-off-by: Tao Ma <tao.ma@oracle.com>
---
fs/ocfs2/super.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index 79ff8d9..4601a57 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -1766,13 +1766,8 @@ static int ocfs2_mount_volume(struct super_block *sb)
}
status = ocfs2_truncate_log_init(osb);
- if (status < 0) {
+ if (status < 0)
mlog_errno(status);
- goto leave;
- }
-
- if (ocfs2_mount_local(osb))
- goto leave;
leave:
if (unlock_super)
--
1.6.1.40.g8ea6a
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume.
2009-05-18 22:47 [Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume Tao Ma
@ 2009-05-19 21:17 ` Sunil Mushran
2009-06-04 2:24 ` Joel Becker
1 sibling, 0 replies; 3+ messages in thread
From: Sunil Mushran @ 2009-05-19 21:17 UTC (permalink / raw)
To: ocfs2-devel
Tao Ma wrote:
> No need for nonsense "goto leave" in the end of ocfs2_mount_volume.
>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
>
Remove redundant gotos in ocfs2_mount_volume().
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
> ---
> fs/ocfs2/super.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 79ff8d9..4601a57 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1766,13 +1766,8 @@ static int ocfs2_mount_volume(struct super_block *sb)
> }
>
> status = ocfs2_truncate_log_init(osb);
> - if (status < 0) {
> + if (status < 0)
> mlog_errno(status);
> - goto leave;
> - }
> -
> - if (ocfs2_mount_local(osb))
> - goto leave;
>
> leave:
> if (unlock_super)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume.
2009-05-18 22:47 [Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume Tao Ma
2009-05-19 21:17 ` Sunil Mushran
@ 2009-06-04 2:24 ` Joel Becker
1 sibling, 0 replies; 3+ messages in thread
From: Joel Becker @ 2009-06-04 2:24 UTC (permalink / raw)
To: ocfs2-devel
On Tue, May 19, 2009 at 06:47:20AM +0800, Tao Ma wrote:
> No need for nonsense "goto leave" in the end of ocfs2_mount_volume.
>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
This is now in the merge-window branch of ocfs2.git.
Joel
--
"Only a life lived for others is a life worth while."
-Albert Einstein
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-04 2:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-18 22:47 [Ocfs2-devel] [PATCH] ocfs2/trivial: Code cleanup of ocfs2_mount_volume Tao Ma
2009-05-19 21:17 ` Sunil Mushran
2009-06-04 2:24 ` Joel Becker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.