fix rtc_cmos bug

fix rtc_cmos bug

[ye janboe]

    fix  Bug 13326 -  Null pointer dereference in rtc-cmos driver
    http://bugzilla.kernel.org/show_bug.cgi?id=13326

    Signed-off-by: janboe <janboe.ye@gmail.com>

diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 23e10b6..da132f6 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -1179,7 +1179,9 @@ static int __init cmos_init(void)
        int retval = 0;

 #ifdef CONFIG_PNP
-       pnp_register_driver(&cmos_pnp_driver);
+       retval = pnp_register_driver(&cmos_pnp_driver);
+       if (retval)
+               return retval;
 #endif

        if (!cmos_rtc.dev)

Re: fix rtc_cmos bug

[ye janboe]

my fix is wrong?

Why no one ack this patch?

Thanks

Janboe

2009/5/17 ye janboe <janboe.ye@gmail.com>:
>    fix  Bug 13326 -  Null pointer dereference in rtc-cmos driver
>    http://bugzilla.kernel.org/show_bug.cgi?id=13326
>
>    Signed-off-by: janboe <janboe.ye@gmail.com>
>
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index 23e10b6..da132f6 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -1179,7 +1179,9 @@ static int __init cmos_init(void)
>        int retval = 0;
>
>  #ifdef CONFIG_PNP
> -       pnp_register_driver(&cmos_pnp_driver);
> +       retval = pnp_register_driver(&cmos_pnp_driver);
> +       if (retval)
> +               return retval;
>  #endif
>
>        if (!cmos_rtc.dev)
>

Re: fix rtc_cmos bug

[Ozan Çağlayan]

ye janboe wrote On 20-05-2009 08:17:
> my fix is wrong?
>
> Why no one ack this patch?
>
> Thanks
>
> Janboe
>
>   

AFAIK any fix in a driver which causes this oops is a partial fix
because the case should be handled in driver core. This is what the
patch suggested does actually:

http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/driver-core.current/driver-core-do-not-oops-when-driver_unregister-is-called-for-unregistered-drivers.patch

Re: fix rtc_cmos bug

[ye janboe]

So if register failed, unregister is requested to invoked, right?

Anyway, thank you for your answer.


2009/5/20 Ozan Çağlayan <ozan@pardus.org.tr>:
> ye janboe wrote On 20-05-2009 08:17:
>> my fix is wrong?
>>
>> Why no one ack this patch?
>>
>> Thanks
>>
>> Janboe
>>
>>
>
> AFAIK any fix in a driver which causes this oops is a partial fix
> because the case should be handled in driver core. This is what the
> patch suggested does actually:
>
> http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/driver-core.current/driver-core-do-not-oops-when-driver_unregister-is-called-for-unregistered-drivers.patch
>
>
>