All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <roel.kluin@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] beyond ARRAY_SIZE of s3c64xx_i2s
Date: Wed, 20 May 2009 17:09:50 +0200	[thread overview]
Message-ID: <4A141D3E.7030609@gmail.com> (raw)

Do not go beyond ARRAY_SIZE of s3c64xx_i2s

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
In this case you are Maintainer, correct?

diff --git a/sound/soc/s3c24xx/s3c64xx-i2s.c b/sound/soc/s3c24xx/s3c64xx-i2s.c
index 33c5de7..f2d3021 100644
--- a/sound/soc/s3c24xx/s3c64xx-i2s.c
+++ b/sound/soc/s3c24xx/s3c64xx-i2s.c
@@ -126,7 +126,7 @@ static int s3c64xx_i2s_probe(struct platform_device *pdev,
 
 	dev_dbg(dev, "%s: probing dai %d\n", __func__, pdev->id);
 
-	if (pdev->id < 0 || pdev->id > ARRAY_SIZE(s3c64xx_i2s)) {
+	if (pdev->id < 0 || pdev->id >= ARRAY_SIZE(s3c64xx_i2s)) {
 		dev_err(dev, "id %d out of range\n", pdev->id);
 		return -EINVAL;
 	}

             reply	other threads:[~2009-05-20 15:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-20 15:09 Roel Kluin [this message]
2009-05-20 15:14 ` [PATCH] beyond ARRAY_SIZE of s3c64xx_i2s Mark Brown
2009-05-21 17:59   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A141D3E.7030609@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.