[PATCH] beyond ARRAY_SIZE of s3c64xx_i2s

[PATCH] beyond ARRAY_SIZE of s3c64xx_i2s

[Roel Kluin]

Do not go beyond ARRAY_SIZE of s3c64xx_i2s

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
In this case you are Maintainer, correct?

diff --git a/sound/soc/s3c24xx/s3c64xx-i2s.c b/sound/soc/s3c24xx/s3c64xx-i2s.c
index 33c5de7..f2d3021 100644
--- a/sound/soc/s3c24xx/s3c64xx-i2s.c
+++ b/sound/soc/s3c24xx/s3c64xx-i2s.c
@@ -126,7 +126,7 @@ static int s3c64xx_i2s_probe(struct platform_device *pdev,
 
 	dev_dbg(dev, "%s: probing dai %d\n", __func__, pdev->id);
 
-	if (pdev->id < 0 || pdev->id > ARRAY_SIZE(s3c64xx_i2s)) {
+	if (pdev->id < 0 || pdev->id >= ARRAY_SIZE(s3c64xx_i2s)) {
 		dev_err(dev, "id %d out of range\n", pdev->id);
 		return -EINVAL;
 	}

Re: [PATCH] beyond ARRAY_SIZE of s3c64xx_i2s

[Mark Brown]

On Wed, May 20, 2009 at 05:09:50PM +0200, Roel Kluin wrote:
> Do not go beyond ARRAY_SIZE of s3c64xx_i2s
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Looks good, I'll apply this.

> ---
> In this case you are Maintainer, correct?

Yes, for anything in sound/soc.

Re: [PATCH] beyond ARRAY_SIZE of s3c64xx_i2s

[Mark Brown]

On Wed, May 20, 2009 at 04:14:46PM +0100, Mark Brown wrote:
> On Wed, May 20, 2009 at 05:09:50PM +0200, Roel Kluin wrote:
> > Do not go beyond ARRAY_SIZE of s3c64xx_i2s
> > 
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

> Looks good, I'll apply this.

...or not, since it doesn't apply against current ALSA and the issue has
been fixed in a different way already.  I guess you're running some sort
of script looking for these issues, probably against current mainline?
It might be worth considering running against -next instead since that
will ensure that your patches apply more easily to people's current
development trees, or checking your results against -next to see if the
issue is still present.