chcat fixes

chcat fixes

[Daniel J Walsh]

Expansion of categores is still broken.  Here is a patch to fix.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: chcat fixes

[Christopher J. PeBenito]

On Wed, 2009-05-20 at 15:00 -0400, Daniel J Walsh wrote:
> Expansion of categores is still broken.  Here is a patch to fix.

Missing attachment.

-- 
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: chcat fixes

[Daniel J Walsh]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

On 05/20/2009 04:05 PM, Chad Sellers wrote:
> On 5/20/09 3:00 PM, "Daniel J Walsh"<dwalsh@redhat.com>  wrote:
>
>> Expansion of categores is still broken.  Here is a patch to fix.
>>
> This message appears to be missing a patch.
>
> Thanks,
> Chad
>


[-- Attachment #2: policycoreutils-chcat.patch --]
[-- Type: text/plain, Size: 939 bytes --]

--- nsapolicycoreutils/scripts/chcat	2009-01-13 08:45:35.000000000 -0500
+++ policycoreutils-2.0.62/scripts/chcat	2009-05-04 13:40:26.000000000 -0400
@@ -281,14 +281,14 @@
 def expandCats(cats):
     newcats = []
     for c in cats:
-        if c.find(".") != -1:
-            c = c.split(".")
-            for i in range(int(c[0][1:]), int(c[1][1:]) + 1):
-                x = ("c%d" % i)
-                if x not in newcats:
-                    newcats.append("c%d" % i)
-        else:
-            for i in c.split(","):
+        for i in c.split(","):
+            if i.find(".") != -1:
+                j = i.split(".")
+                for k in range(int(j[0][1:]), int(j[1][1:]) + 1):
+                    x = ("c%d" % k)
+                    if x not in newcats:
+                        newcats.append(x)
+            else:
                 if i not in newcats:
                     newcats.append(i)
     if len(newcats) > 25:

Re: chcat fixes

[Joshua Brindle]

Daniel J Walsh wrote:
> On 05/20/2009 04:05 PM, Chad Sellers wrote:
>> On 5/20/09 3:00 PM, "Daniel J Walsh"<dwalsh@redhat.com> wrote:
>>
>>> Expansion of categores is still broken. Here is a patch to fix.
>>>

Its a shame that we are still hard coding the format for categories into tools, 
we might as well have hardcoded the format into the security server.

Stephen - any chance we could get selinuxfs interfaces that export 
level/category data so that tools can use that instead of hardcoding this stuff?

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: chcat fixes

[Stephen Smalley]

On Fri, 2009-06-19 at 13:30 -0400, Joshua Brindle wrote:
> Daniel J Walsh wrote:
> > On 05/20/2009 04:05 PM, Chad Sellers wrote:
> >> On 5/20/09 3:00 PM, "Daniel J Walsh"<dwalsh@redhat.com> wrote:
> >>
> >>> Expansion of categores is still broken. Here is a patch to fix.
> >>>
> 
> Its a shame that we are still hard coding the format for categories into tools, 
> we might as well have hardcoded the format into the security server.
> 
> Stephen - any chance we could get selinuxfs interfaces that export 
> level/category data so that tools can use that instead of hardcoding this stuff?

That would be fine with me.  Not only level/category data, but also
other policy information (e.g. user data) to allow obsoleting
of /selinux/users.

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: chcat fixes

[Joshua Brindle]

Daniel J Walsh wrote:
> On 05/20/2009 04:05 PM, Chad Sellers wrote:
>> On 5/20/09 3:00 PM, "Daniel J Walsh"<dwalsh@redhat.com> wrote:
>>
>>> Expansion of categores is still broken. Here is a patch to fix.
>>>
>> This message appears to be missing a patch.
>>
>> Thanks,
>> Chad
>>

Merged in policycoreutils 2.0.64


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.