stdvga + videoram config option

stdvga + videoram config option

[Andrew Lyon]

I just tried to use the stdvga and videoram options to create a hvm
with 16mb video ram, but it fails to start due to qemu device model
failure:


grep -E "stdvga|videoram" windows7.cfg
stdvga=1
videoram=16


xm create windows7.cfg
Using config file "./windows7.cfg".
Error: Domain 'windows7' does not exist.

The Xen log shows that it failed due to qemu failure:

.[2009-05-21 08:55:20 8052] WARNING (image:495) domain windows7:
device model failure: pid 6850: exited with nonzero status 255; see
/var/log/xen/qemu-dm-windows7.log

The qemu log:


cat /var/log/xen/qemu-dm-windows7.log
domid: 18
qemu: the number of cpus is 8
config qemu network with xen bridge for  tap18.0 xenbr0
Machine `xenfv' requires 17104896 bytes of memory

Andy

Re: stdvga + videoram config option

[Stefano Stabellini]

Andrew Lyon wrote:

> I just tried to use the stdvga and videoram options to create a hvm
> with 16mb video ram, but it fails to start due to qemu device model
> failure:



that's due to a stupid initial configuration check done by qemu that is
actually meaningless for us (at least on x86).

This patch should fix the problem, I kept the check in place only in
case it might be of some use for the ia64 people.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

---

diff --git a/vl.c b/vl.c
index b5bb5cb..3506977 100644
--- a/vl.c
+++ b/vl.c
@@ -4801,7 +4801,6 @@ int main(int argc, char **argv, char **envp)
     machine = first_machine;
     cpu_model = NULL;
     initrd_filename = NULL;
-    ram_size = VGA_RAM_SIZE;
 #ifdef CONFIG_GDBSTUB
     use_gdbstub = 0;
     gdbstub_port = DEFAULT_GDBSTUB_PORT;
@@ -5654,13 +5653,6 @@ int main(int argc, char **argv, char **envp)
     }
 #endif
 
-#if defined (__ia64__)
-    if (ram_size > VGA_IO_START)
-        ram_size += VGA_IO_SIZE; /* skip VGA I/O hole */
-    if (ram_size > MMIO_START)
-        ram_size += 1 * MEM_G; /* skip 3G-4G MMIO, LEGACY_IO_SPACE etc. */
-#endif
-
     /* init the bluetooth world */
     for (i = 0; i < nb_bt_opts; i++)
         if (bt_parse(bt_opts[i]))
@@ -5677,6 +5669,14 @@ int main(int argc, char **argv, char **envp)
 
     phys_ram_size = (machine->ram_require + vga_ram_size) & ~RAMSIZE_FIXED;
 
+#if defined (__ia64__)
+    ram_size = vga_ram_size;
+    if (ram_size > VGA_IO_START)
+        ram_size += VGA_IO_SIZE; /* skip VGA I/O hole */
+    if (ram_size > MMIO_START)
+        ram_size += 1 * MEM_G; /* skip 3G-4G MMIO, LEGACY_IO_SPACE etc. */
+#endif
+
     if (machine->ram_require & RAMSIZE_FIXED) {
         if (ram_size > 0) {
             if (ram_size < phys_ram_size) {

Re: stdvga + videoram config option

[Andrew Lyon]

On Thu, May 21, 2009 at 6:08 PM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Applied, thanks.  (This will appear in qemu-xen-unstable staging very
> shortly; it will appear in qemu-xen-unstable proper when the tests
> pass or if we push manually.)
>
> Ian.
>

Tested and working.

Andy

Re: stdvga + videoram config option

[KUWAMURA Shin'ya]

[-- Attachment #1: Type: Text/Plain, Size: 621 bytes --]

Hi,

>>>>> On Thu, 21 May 2009 13:00:13 +0100
>>>>> stefano.stabellini@eu.citrix.com(Stefano Stabellini)  said:
> 
> that's due to a stupid initial configuration check done by qemu that is
> actually meaningless for us (at least on x86).
> 
> This patch should fix the problem, I kept the check in place only in
> case it might be of some use for the ia64 people.

Unfortunately, this patch breaks ia64. HVM domains cannot be created:
  Machine `xenfv' requires 4521984 bytes of memory

> +    ram_size = vga_ram_size;

This line do not need.

Signed-off-by: KUWAMURA Shin'ya <kuwa@jp.fujitsu.com>
-- 
  KUWAMURA Shin'ya

[-- Attachment #2: fix-ram_size-calculation-for-ia64.patch --]
[-- Type: Text/X-Patch, Size: 401 bytes --]

diff --git a/vl.c b/vl.c
index 3506977..7284be4 100644
--- a/vl.c
+++ b/vl.c
@@ -5670,7 +5670,6 @@ int main(int argc, char **argv, char **envp)
     phys_ram_size = (machine->ram_require + vga_ram_size) & ~RAMSIZE_FIXED;
 
 #if defined (__ia64__)
-    ram_size = vga_ram_size;
     if (ram_size > VGA_IO_START)
         ram_size += VGA_IO_SIZE; /* skip VGA I/O hole */
     if (ram_size > MMIO_START)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: stdvga + videoram config option

[KUWAMURA Shin'ya]

[-- Attachment #1: Type: Text/Plain, Size: 900 bytes --]

Hi Ian,

Could you commit this patch?
Without it, guests cannot be created on ia64 because of qemu-dm's error.

Signed-off-by: KUWAMURA Shin'ya <kuwa@jp.fujitsu.com>

On <20090525.110952.139538434.kuwa@jp.fujitsu.com>,
 "KUWAMURA Shin'ya" wrote:
> 
> >>>>> On Thu, 21 May 2009 13:00:13 +0100
> >>>>> stefano.stabellini@eu.citrix.com(Stefano Stabellini)  said:
> > 
> > that's due to a stupid initial configuration check done by qemu that is
> > actually meaningless for us (at least on x86).
> > 
> > This patch should fix the problem, I kept the check in place only in
> > case it might be of some use for the ia64 people.
> 
> Unfortunately, this patch breaks ia64. HVM domains cannot be created:
>   Machine `xenfv' requires 4521984 bytes of memory
> 
> > +    ram_size = vga_ram_size;
> 
> This line do not need.
> 
> Signed-off-by: KUWAMURA Shin'ya <kuwa@jp.fujitsu.com>

-- 
  KUWAMURA Shin'ya

[-- Attachment #2: fix-ram_size-calculation-for-ia64.patch --]
[-- Type: Text/X-Patch, Size: 401 bytes --]

diff --git a/vl.c b/vl.c
index 3506977..7284be4 100644
--- a/vl.c
+++ b/vl.c
@@ -5670,7 +5670,6 @@ int main(int argc, char **argv, char **envp)
     phys_ram_size = (machine->ram_require + vga_ram_size) & ~RAMSIZE_FIXED;
 
 #if defined (__ia64__)
-    ram_size = vga_ram_size;
     if (ram_size > VGA_IO_START)
         ram_size += VGA_IO_SIZE; /* skip VGA I/O hole */
     if (ram_size > MMIO_START)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel