All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	sfr@canb.auug.org.au, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: fix irqfd build failure discovered in linux-next
Date: Thu, 21 May 2009 16:29:04 +0300	[thread overview]
Message-ID: <4A155720.7050907@redhat.com> (raw)
In-Reply-To: <4A155669.4010506@novell.com>

Gregory Haskins wrote:
>>>  EXTRA_CFLAGS += -Ivirt/kvm -Iarch/x86/kvm
>>> +EXTRA_CFLAGS += -DKVM_HAVE_EVENTFD
>>>  
>>>   
>>>       
>> The standard idiom for this is to use a Kconfig symbol; see for
>> example HAVE_KVM_IRQCHIP in arch/*/kvm/Kconfig.
>>     
>
> Ah, I didn't realize I could do this in such a contained manner.  I was
> afraid of polluting the top level arch/Kconfig, which is why I went this
> other route.   But I see from your example that this is not the case.  I
> will make a v2 with this change.
>   

Note the situation is not as good as it could be, as you have to 
replicate the Kconfig for each arch.  One day I'll set up 
virt/kvm/Kconfig which will set up defaults, so archs can override them.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2009-05-21 13:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21  7:21 linux-next: kvm tree build failure Stephen Rothwell
2009-05-21  7:32 ` Avi Kivity
2009-05-21  7:37   ` Boaz Harrosh
2009-05-21  7:39     ` Avi Kivity
2009-05-21  7:48       ` Boaz Harrosh
2009-05-21 10:05         ` Avi Kivity
2009-05-21 13:04 ` [PATCH] kvm: fix irqfd build failure discovered in linux-next Gregory Haskins
2009-05-21 13:10   ` Avi Kivity
2009-05-21 13:26     ` Gregory Haskins
2009-05-21 13:29       ` Avi Kivity [this message]
2009-05-21 13:28 ` [PATCH v2] " Gregory Haskins
2009-05-21 13:52   ` Avi Kivity
2009-05-21 14:04     ` Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A155720.7050907@redhat.com \
    --to=avi@redhat.com \
    --cc=ghaskins@novell.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.