From: Avi Kivity <avi@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
sfr@canb.auug.org.au, kvm@vger.kernel.org
Subject: Re: [PATCH v2] kvm: fix irqfd build failure discovered in linux-next
Date: Thu, 21 May 2009 16:52:06 +0300 [thread overview]
Message-ID: <4A155C86.7010604@redhat.com> (raw)
In-Reply-To: <20090521132817.8218.92948.stgit@dev.haskins.net>
Gregory Haskins wrote:
> Stephen Rothwell noted a build failure in arch != x86 in last nights
> linux-next tree, as noted here:
>
> http://lkml.org/lkml/2009/5/21/32
>
> This patch corrects the build issue by requiring explicit support for
> IRQFD to be defined, and only defining it on x86 (the only arch fully
> supported). The code itself isnt architecture dependent, but we need
> to add a new file to each makefile, advertise the capability, and
> of course, test that it works for each supported arch. We will submit
> patches against each relevant arch at a later time to enable support
> there as well.
>
>
> +config HAVE_KVM_EVENTFD
> + bool
> + default y
> +
>
The build system will complain if it sees a symbol used but not defined;
so you have to define it for all four archs. So I went ahead and did
virt/kvm/Kconfig and adapted your patch to use it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-21 13:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 7:21 linux-next: kvm tree build failure Stephen Rothwell
2009-05-21 7:32 ` Avi Kivity
2009-05-21 7:37 ` Boaz Harrosh
2009-05-21 7:39 ` Avi Kivity
2009-05-21 7:48 ` Boaz Harrosh
2009-05-21 10:05 ` Avi Kivity
2009-05-21 13:04 ` [PATCH] kvm: fix irqfd build failure discovered in linux-next Gregory Haskins
2009-05-21 13:10 ` Avi Kivity
2009-05-21 13:26 ` Gregory Haskins
2009-05-21 13:29 ` Avi Kivity
2009-05-21 13:28 ` [PATCH v2] " Gregory Haskins
2009-05-21 13:52 ` Avi Kivity [this message]
2009-05-21 14:04 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A155C86.7010604@redhat.com \
--to=avi@redhat.com \
--cc=ghaskins@novell.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.