[Qemu-devel] Re: [PATCH STABLE 2/2] net: Fix -net socket parameter checks

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]

Glauber Costa wrote:
> On Thu, May 21, 2009 at 06:26:33PM +0200, Jan Kiszka wrote:
>> Glauber Costa wrote:
>>> On Thu, May 21, 2009 at 08:23:22AM +0200, Jan Kiszka wrote:
>>>> Glauber Costa wrote:
>>>>> My commit ea053add700d8abe203cd79a9ffb082aee4eabc0 broke -net socket by
>>>>> overwriting an intermediate buffer in the added check_param. Fix this
>>>>> by switching check_param to automatic buffer allocation and release, ie.
>>>>> callers no longer have to worry about providing a scratch buffer.
>>>> That commit was buggy, too, and is awaiting to be fixed in unstable by
>>>> http://permalink.gmane.org/gmane.comp.emulators.qemu/43041.
>>>>
>>>> But more importantly, it makes no sense in stable because its "heart",
>>>> param checking for -net is only in unstable (and that's perfectly fine).
>>> My interest was in the previous one, since it fixes a bug reported by a Fedora
>>> user. I picked this one, only because it fixes the fix ;-)
>>> But I can happily leave it out, if you think it is better.
>> This patch 2 has never been a fix of patch 1 in your series. I agree
>> that 1/2 is worth considering for stable, but that one never required
>> any addon fix.
> I got the wrong impression from your changelog then.
> 
> Thanks for taking a look

Oh, off-by-one while picking up the hash for this changelog. Should have
been 8e4416af458b5fdfc81950005e358de02511eb9f. My bad.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]