From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects
Date: Sun, 24 May 2009 11:15:26 +0300 [thread overview]
Message-ID: <4A19021E.8080205@redhat.com> (raw)
In-Reply-To: <4A170535.3090007@web.de>
Jan Kiszka wrote:
> This redundancy breaks subtly when building against recent OpenSUSE
> kernels.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> x86/Kbuild | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/x86/Kbuild b/x86/Kbuild
> index e304c79..ade87fc 100644
> --- a/x86/Kbuild
> +++ b/x86/Kbuild
> @@ -13,7 +13,7 @@ endif
> ifeq ($(CONFIG_IOMMU_API),y)
> kvm-objs += iommu.o
> endif
> -kvm-intel-objs := vmx.o vmx-debug.o ../external-module-compat.o
> -kvm-amd-objs := svm.o ../external-module-compat.o
> +kvm-intel-objs := vmx.o vmx-debug.o
> +kvm-amd-objs := svm.o
>
>
IIRC, for really old kernels, some symbols are defined in
external-module-compat.c and needed by kvm-$arch.ko. So we'll have to
export those symbols if we drop the double link (which is a good idea
regardless of the build problem).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-24 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 20:04 [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects Jan Kiszka
2009-05-23 1:36 ` Chris Wright
2009-05-23 11:55 ` Jan Kiszka
2009-05-24 8:17 ` Avi Kivity
2009-05-25 6:49 ` Jan Kiszka
2009-05-25 9:40 ` Avi Kivity
2009-05-24 8:15 ` Avi Kivity [this message]
2009-05-25 6:56 ` [PATCH v2] " Jan Kiszka
2009-05-25 9:36 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A19021E.8080205@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.