All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amerigo Wang <amwang@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, jdike@addtoit.com, mingo@elte.hu,
	sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [Patch 4/4] module: trim exception table in module_free()
Date: Wed, 27 May 2009 13:48:12 +0800	[thread overview]
Message-ID: <4A1CD41C.1000008@redhat.com> (raw)
In-Reply-To: <200905271453.51914.rusty@rustcorp.com.au>

Rusty Russell wrote:
> __ex_table ends up with two entries:
>
> Contents of section __ex_table:
>  0000 0c000000 00000000 0e000000 00000000  ................
>  0010 10000000 0a000000 12000000 0a000000  ................
>
> The first is for the __put_user in .text (extable_not_init()) and the second is 
> for the one in .init.text (init()).
>
> Depending on how the module gets allocated, the one referring to .init.text 
> may be first or last.
>   

Hmm, I understand now. The problem is that we don't know which entries
are for __init, and which are not...

> (You can see here why we haven't fixed this: exceptions in __init in modules 
> are rare, perhaps non-existent).
>   
Agreed.
Is it possible to put extable for __init in a separate section?

Thanks for your explanation!


WARNING: multiple messages have this Message-ID (diff)
From: Amerigo Wang <amwang@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, jdike@addtoit.com, mingo@elte.hu,
	sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [Patch 4/4] module: trim exception table in module_free()
Date: Wed, 27 May 2009 05:48:12 +0000	[thread overview]
Message-ID: <4A1CD41C.1000008@redhat.com> (raw)
In-Reply-To: <200905271453.51914.rusty@rustcorp.com.au>

Rusty Russell wrote:
> __ex_table ends up with two entries:
>
> Contents of section __ex_table:
>  0000 0c000000 00000000 0e000000 00000000  ................
>  0010 10000000 0a000000 12000000 0a000000  ................
>
> The first is for the __put_user in .text (extable_not_init()) and the second is 
> for the one in .init.text (init()).
>
> Depending on how the module gets allocated, the one referring to .init.text 
> may be first or last.
>   

Hmm, I understand now. The problem is that we don't know which entries
are for __init, and which are not...

> (You can see here why we haven't fixed this: exceptions in __init in modules 
> are rare, perhaps non-existent).
>   
Agreed.
Is it possible to put extable for __init in a separate section?

Thanks for your explanation!


  reply	other threads:[~2009-05-27  5:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26  8:35 [Patch 0/4] module: merge module_32.c and module_64.c Amerigo Wang
2009-05-26  8:35 ` [Patch 1/4] x86 module: merge the same functions in " Amerigo Wang
2009-05-26  8:35 ` [Patch 2/4] x86 module: merge the rest functions with macros Amerigo Wang
2009-05-26  9:21   ` Christoph Hellwig
2009-05-26 10:02     ` Amerigo Wang
2009-05-26  8:35 ` [Patch 3/4] uml module: fix uml build process due to this merge Amerigo Wang
2009-05-26  8:35 ` [Patch 4/4] module: trim exception table in module_free() Amerigo Wang
2009-05-27  2:21   ` Rusty Russell
2009-05-27  2:33     ` Rusty Russell
2009-05-27  3:11     ` Amerigo Wang
2009-05-27  3:11       ` Amerigo Wang
2009-05-27  5:23       ` Rusty Russell
2009-05-27  5:35         ` Rusty Russell
2009-05-27  5:48         ` Amerigo Wang [this message]
2009-05-27  5:48           ` Amerigo Wang
2009-05-27  7:46         ` Amerigo Wang
2009-05-27  7:46           ` Amerigo Wang
2009-05-28  6:55           ` Rusty Russell
2009-05-28  7:07             ` Rusty Russell
2009-05-31  5:15             ` Amerigo Wang
2009-05-31  5:15               ` Amerigo Wang
2009-06-01 12:28               ` Rusty Russell
2009-06-01 12:40                 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1CD41C.1000008@redhat.com \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=jdike@addtoit.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rusty@rustcorp.com.au \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.