From: john cooper <john.cooper@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: KVM list <kvm@vger.kernel.org>,
qemu-devel@nongnu.org, rusty@rustcorp.com.au,
john.cooper@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3
Date: Wed, 27 May 2009 11:06:26 -0400 [thread overview]
Message-ID: <4A1D56F2.5090207@redhat.com> (raw)
In-Reply-To: <20090527074919.GB7356@lst.de>
Christoph Hellwig wrote:
> This looks functionally correct, but pretty far from normal kernel coding
> style.
I tend to avoid 'goto's.
Christoph Hellwig wrote:
>> /*
>> * IDE-compatible identify ioctl.
>> *
>> * Currenlyt only returns the serial number and leaves all other fields
>> * zero.
>> */
>
> Btw, thinking about it the rest of the information in the ioctl should
> probably be filled up with faked data, similar to how we do it for
> the ide emulation inside qemu.
Doing so crossed my mind but thought it may be better to
start here and provide data on an as-needed basis. But
as you point out there is precedent (and likely reason)
for hw/ide.c:ide_identify() doing as such. I don't have
a strong bias either way. Comments from others?
-john
--
john.cooper@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: john cooper <john.cooper@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: john.cooper@redhat.com, rusty@rustcorp.com.au,
qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3
Date: Wed, 27 May 2009 11:06:26 -0400 [thread overview]
Message-ID: <4A1D56F2.5090207@redhat.com> (raw)
In-Reply-To: <20090527074919.GB7356@lst.de>
Christoph Hellwig wrote:
> This looks functionally correct, but pretty far from normal kernel coding
> style.
I tend to avoid 'goto's.
Christoph Hellwig wrote:
>> /*
>> * IDE-compatible identify ioctl.
>> *
>> * Currenlyt only returns the serial number and leaves all other fields
>> * zero.
>> */
>
> Btw, thinking about it the rest of the information in the ioctl should
> probably be filled up with faked data, similar to how we do it for
> the ide emulation inside qemu.
Doing so crossed my mind but thought it may be better to
start here and provide data on an as-needed basis. But
as you point out there is precedent (and likely reason)
for hw/ide.c:ide_identify() doing as such. I don't have
a strong bias either way. Comments from others?
-john
--
john.cooper@redhat.com
next prev parent reply other threads:[~2009-05-27 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 0:27 [PATCH 2/2] Add serial number support for virtio_blk, V3 john cooper
2009-05-27 0:27 ` [Qemu-devel] " john cooper
2009-05-27 7:49 ` Christoph Hellwig
2009-05-27 7:49 ` Christoph Hellwig
2009-05-27 7:54 ` Christoph Hellwig
2009-05-29 4:04 ` john cooper
2009-05-29 4:04 ` john cooper
2009-05-27 12:53 ` Rusty Russell
2009-05-27 12:53 ` Rusty Russell
2009-05-29 4:05 ` john cooper
2009-05-29 4:05 ` john cooper
2009-05-27 15:06 ` john cooper [this message]
2009-05-27 15:06 ` john cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1D56F2.5090207@redhat.com \
--to=john.cooper@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.