From: Karl Beldan <karl.beldan@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Cliff Cai <cliff.cai@analog.com>
Subject: Re: [Uclinux-dist-devel] [PATCH 2/5] ASoC codec: SSM2602: assign last substream to the master when shutting down
Date: Thu, 04 Jun 2009 10:17:02 +0200 [thread overview]
Message-ID: <4A2782FE.3080103@gmail.com> (raw)
In-Reply-To: <8bd0f97a0906031826j647efa0bs1ffb6492cfd0ccd8@mail.gmail.com>
Mike Frysinger wrote:
> On Wed, Jun 3, 2009 at 10:53, Mark Brown wrote:
>> On Wed, Jun 03, 2009 at 08:37:54AM -0400, Mike Frysinger wrote:
>>> On Wed, Jun 3, 2009 at 06:52, Mark Brown wrote:
>>>> However, given that this fix has missed two kernel releases due to the
>>>> very slow rate of responses to review comments I've applied it so users
>>>> get the benefit of the bug fix.
>>> not sure what you're referring to
>> This looks like a respin of a fix which was originally submitted back in
>> 2.6.29 era or so. IIRC there's been two or three versions, each of
>> which needed fixes.
>
> it could be. i was going by the changes that werent in 2.6.30. i
> thought i looked for previous submissions, but i must have missed
> previous attempts. i'm not familiar with alsa stuff, so i'm not
> always sure when i need to bang on Cliff to get things fixed up
> (changes split / better comments / etc...).
>
Anyways, this commit has been trying to fix something already fixed since the
first submission and if you look at its effect on the current tree you will see
duplicate code.
--
Karl
next prev parent reply other threads:[~2009-06-04 8:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 4:18 [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates Mike Frysinger
2009-06-02 4:18 ` [PATCH 2/5] ASoC codec: SSM2602: assign last substream to the master when shutting down Mike Frysinger
2009-06-03 10:52 ` Mark Brown
2009-06-03 12:37 ` [Uclinux-dist-devel] " Mike Frysinger
2009-06-03 14:53 ` Mark Brown
2009-06-04 1:26 ` Mike Frysinger
2009-06-04 8:17 ` Karl Beldan [this message]
2009-06-04 8:22 ` Mike Frysinger
2009-06-04 8:31 ` Cai, Cliff
2009-06-04 8:45 ` Mike Frysinger
2009-06-04 8:56 ` Cai, Cliff
2009-06-04 9:37 ` Karl Beldan
2009-06-04 8:40 ` Karl Beldan
2009-06-04 8:50 ` Cai, Cliff
2009-06-04 8:55 ` Mike Frysinger
2009-06-04 8:59 ` Mark Brown
2009-06-04 9:04 ` Mike Frysinger
2009-06-13 9:37 ` Karl Beldan
2009-06-13 10:10 ` Mike Frysinger
2009-06-13 10:44 ` Mark Brown
2009-06-13 10:47 ` Mike Frysinger
2009-06-13 10:59 ` Mark Brown
2009-06-13 11:03 ` Mike Frysinger
2009-06-13 11:06 ` Mark Brown
2009-06-14 8:15 ` Takashi Iwai
2009-06-15 2:40 ` Cai, Cliff
2009-06-02 4:18 ` [PATCH 3/5] ASoC: Blackfin: tweak how we initialize the SPORT Mike Frysinger
2009-06-03 10:29 ` Mark Brown
2009-06-04 2:36 ` [PATCH 3/5] ASoC: Blackfin: tweak how weinitialize " Cai, Cliff
2009-06-04 10:51 ` Mark Brown
2009-06-08 2:14 ` [PATCH 3/5] ASoC: Blackfin: tweak howweinitialize " Cai, Cliff
2009-06-20 15:29 ` [PATCH] ASoC: Blackfin: keep better track of SPORT configuration state Mike Frysinger
2009-06-20 18:41 ` Mark Brown
2009-06-02 4:18 ` [PATCH 4/5] ASoC: Blackfin: set the transfer size according the ac97_frame size Mike Frysinger
2009-06-03 10:30 ` Mark Brown
2009-06-02 4:18 ` [PATCH 5/5] ASoC: Blackfin: document how anomaly 05000250 is handled Mike Frysinger
2009-06-03 10:30 ` Mark Brown
2009-06-03 10:26 ` [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates Mark Brown
2009-06-03 12:11 ` Karl Beldan
2009-06-03 12:15 ` Mark Brown
2009-06-03 12:42 ` Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2782FE.3080103@gmail.com \
--to=karl.beldan@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cliff.cai@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.