From: Karl Beldan <karl.beldan@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org, Mike Frysinger <vapier@gentoo.org>,
Cliff Cai <cliff.cai@analog.com>
Subject: Re: [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates
Date: Wed, 03 Jun 2009 14:42:02 +0200 [thread overview]
Message-ID: <4A266F9A.9050503@gmail.com> (raw)
In-Reply-To: <20090603121513.GB25676@sirena.org.uk>
Mark Brown wrote:
> On Wed, Jun 03, 2009 at 02:11:36PM +0200, Karl Beldan wrote:
>
>> These samples rates are supported by the codec, updating coeff_div
>> would be a better move.
>
> It looks like the driver only supports a limited subset of the chip
> features as it is - there's also comments saying it supports asymmetric
> configurations but currently the driver only does symmetric record and
> playback setups.
True. The comment was from me.
The codec supports these rates and the driver only needs little
modification to support them (just update an array - coeff_div).
Though this commit is better than nothing, updating coeff_div seems IMO
the thing to do. This change being trivial, the commit feels like a
feature cut.
--
Karl
prev parent reply other threads:[~2009-06-03 12:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 4:18 [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates Mike Frysinger
2009-06-02 4:18 ` [PATCH 2/5] ASoC codec: SSM2602: assign last substream to the master when shutting down Mike Frysinger
2009-06-03 10:52 ` Mark Brown
2009-06-03 12:37 ` [Uclinux-dist-devel] " Mike Frysinger
2009-06-03 14:53 ` Mark Brown
2009-06-04 1:26 ` Mike Frysinger
2009-06-04 8:17 ` Karl Beldan
2009-06-04 8:22 ` Mike Frysinger
2009-06-04 8:31 ` Cai, Cliff
2009-06-04 8:45 ` Mike Frysinger
2009-06-04 8:56 ` Cai, Cliff
2009-06-04 9:37 ` Karl Beldan
2009-06-04 8:40 ` Karl Beldan
2009-06-04 8:50 ` Cai, Cliff
2009-06-04 8:55 ` Mike Frysinger
2009-06-04 8:59 ` Mark Brown
2009-06-04 9:04 ` Mike Frysinger
2009-06-13 9:37 ` Karl Beldan
2009-06-13 10:10 ` Mike Frysinger
2009-06-13 10:44 ` Mark Brown
2009-06-13 10:47 ` Mike Frysinger
2009-06-13 10:59 ` Mark Brown
2009-06-13 11:03 ` Mike Frysinger
2009-06-13 11:06 ` Mark Brown
2009-06-14 8:15 ` Takashi Iwai
2009-06-15 2:40 ` Cai, Cliff
2009-06-02 4:18 ` [PATCH 3/5] ASoC: Blackfin: tweak how we initialize the SPORT Mike Frysinger
2009-06-03 10:29 ` Mark Brown
2009-06-04 2:36 ` [PATCH 3/5] ASoC: Blackfin: tweak how weinitialize " Cai, Cliff
2009-06-04 10:51 ` Mark Brown
2009-06-08 2:14 ` [PATCH 3/5] ASoC: Blackfin: tweak howweinitialize " Cai, Cliff
2009-06-20 15:29 ` [PATCH] ASoC: Blackfin: keep better track of SPORT configuration state Mike Frysinger
2009-06-20 18:41 ` Mark Brown
2009-06-02 4:18 ` [PATCH 4/5] ASoC: Blackfin: set the transfer size according the ac97_frame size Mike Frysinger
2009-06-03 10:30 ` Mark Brown
2009-06-02 4:18 ` [PATCH 5/5] ASoC: Blackfin: document how anomaly 05000250 is handled Mike Frysinger
2009-06-03 10:30 ` Mark Brown
2009-06-03 10:26 ` [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates Mark Brown
2009-06-03 12:11 ` Karl Beldan
2009-06-03 12:15 ` Mark Brown
2009-06-03 12:42 ` Karl Beldan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A266F9A.9050503@gmail.com \
--to=karl.beldan@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cliff.cai@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.